> On April 18, 2016, 8:19 p.m., Aravindan Vijayan wrote: > > ambari-metrics/ambari-metrics-hadoop-sink/src/main/java/org/apache/hadoop/metrics2/sink/timeline/HadoopTimelineMetricsSink.java, > > line 280 > > <https://reviews.apache.org/r/46342/diff/1/?file=1348632#file1348632line280> > > > > switch(String) may not be compatible with Java 7. Can we change to "if"?
https://docs.oracle.com/javase/8/docs/technotes/guides/language/strings-switch.html here it says it's ok to use switch in jdk 7 - Jian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46342/#review129418 ----------------------------------------------------------- On April 18, 2016, 10:20 p.m., Jian He wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46342/ > ----------------------------------------------------------- > > (Updated April 18, 2016, 10:20 p.m.) > > > Review request for Ambari, Aravindan Vijayan, Sumit Mohanty, and Sid Wagle. > > > Repository: ambari > > > Description > ------- > > BUG-55643 Add container metrics in AMS > > > Diffs > ----- > > > ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/AbstractTimelineMetricsSink.java > 28d3b9c > > ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/ContainerMetric.java > PRE-CREATION > > ambari-metrics/ambari-metrics-hadoop-sink/src/main/java/org/apache/hadoop/metrics2/sink/timeline/HadoopTimelineMetricsSink.java > db8791f > > ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/HBaseTimelineMetricStore.java > ab11333 > > ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/PhoenixHBaseAccessor.java > e434d33 > > ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricConfiguration.java > c0093a0 > > ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricStore.java > 2f08f3f > > ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/query/PhoenixTransactSQL.java > 0efa68f > > ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/webapp/TimelineWebServices.java > d2526a0 > > ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/ITPhoenixHBaseAccessor.java > f61d619 > > ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TestTimelineMetricStore.java > 61d6e71 > > Diff: https://reviews.apache.org/r/46342/diff/ > > > Testing > ------- > > Did end-to-end testing on cluster, NM can publish the container metrics, and > AMS will store that in phoenix > > > File Attachments > ---------------- > > patch v2 - address comments > > https://reviews.apache.org/media/uploaded/files/2016/04/18/aa152e6c-df4c-44cf-a28f-5caedf0d58cf__BUG-55643.2.patch > > > Thanks, > > Jian He > >