> On April 15, 2016, 12:10 a.m., Jayush Luniya wrote: > > Ship It!
@Ajit, can you close this review? - Jayush ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46172/#review129039 ----------------------------------------------------------- On April 14, 2016, 4:04 p.m., Ajit Kumar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46172/ > ----------------------------------------------------------- > > (Updated April 14, 2016, 4:04 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Sumit > Mohanty. > > > Bugs: AMBARI-15888 > https://issues.apache.org/jira/browse/AMBARI-15888 > > > Repository: ambari > > > Description > ------- > > Currently delete API on resource provider only takes predicate. Ideally it > should take request object as well which has additional metadata. It will be > required in scenarios like dry-run where it can look at request object to > figure out if current invocation is for dry run or not and behave accordingly. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/api/services/persistence/PersistenceManagerImpl.java > 3037446 > > ambari-server/src/main/java/org/apache/ambari/server/controller/gsinstaller/GSInstallerResourceProvider.java > d403114 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractAuthorizedResourceProvider.java > 0837a5d > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ActionResourceProvider.java > faef86c > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ActiveWidgetLayoutResourceProvider.java > 10eecac > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertDefinitionResourceProvider.java > bcf0205 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertGroupResourceProvider.java > dafd194 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertHistoryResourceProvider.java > f52ee62 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertNoticeResourceProvider.java > f19bea9 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertTargetResourceProvider.java > 3b749d9 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ArtifactResourceProvider.java > 34952f2 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintResourceProvider.java > a4b2aaa > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java > 3e4d7fd > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterControllerImpl.java > e776b5a > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterResourceProvider.java > 51c0db9 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java > a85f939 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ComponentResourceProvider.java > 6236ac2 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ConfigGroupResourceProvider.java > 2677ec7 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ConfigurationResourceProvider.java > f9d12b5 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/CredentialResourceProvider.java > 8a3937a > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/FeedResourceProvider.java > 5087049 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/GroupResourceProvider.java > 0d215ae > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostComponentResourceProvider.java > 39a09a6 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostResourceProvider.java > 322eab8 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostStackVersionResourceProvider.java > b3f353c > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/InstanceResourceProvider.java > 49f968f > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/JobResourceProvider.java > c732842 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/KerberosDescriptorResourceProvider.java > 3cece5d > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/LdapSyncEventResourceProvider.java > 3d18a27 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/MemberResourceProvider.java > 307ed3f > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/PermissionResourceProvider.java > 86f8321 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/PrivilegeResourceProvider.java > 4a44375 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/QuickLinkArtifactResourceProvider.java > ed64342 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ReadOnlyResourceProvider.java > 562aa34 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryResourceProvider.java > 18d597e > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProvider.java > 4bb0e3b > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RequestResourceProvider.java > be13ec0 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RequestScheduleResourceProvider.java > 6a80335 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceConfigVersionResourceProvider.java > beafb1f > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceResourceProvider.java > adfac0c > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/SettingResourceProvider.java > e1f9015 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackArtifactResourceProvider.java > 4d047d5 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackDependencyResourceProvider.java > 02fc8f5 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StageResourceProvider.java > a563420 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/TargetClusterResourceProvider.java > 7fe2b39 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/TaskAttemptResourceProvider.java > 6f8b2cf > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/TaskResourceProvider.java > cb8a343 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ThemeArtifactResourceProvider.java > 4b5c95d > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeGroupResourceProvider.java > e7ca9aa > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java > 4cd0419 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeSummaryResourceProvider.java > cf4b08f > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UserResourceProvider.java > 099cfd4 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/VersionDefinitionResourceProvider.java > f8f8290 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ViewInstanceResourceProvider.java > abdda7f > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ViewPermissionResourceProvider.java > 979e214 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ViewResourceProvider.java > ee01927 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ViewVersionResourceProvider.java > 570766d > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/WidgetLayoutResourceProvider.java > 67ccafd > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/WidgetResourceProvider.java > e6953a9 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/WorkflowResourceProvider.java > a925f26 > > ambari-server/src/main/java/org/apache/ambari/server/controller/jdbc/JDBCResourceProvider.java > e969505 > > ambari-server/src/main/java/org/apache/ambari/server/controller/spi/ClusterController.java > ec7425e > > ambari-server/src/main/java/org/apache/ambari/server/controller/spi/ResourceProvider.java > de1c9dd > > ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/CleanupServerAction.java > b6c2f12 > > ambari-server/src/main/java/org/apache/ambari/server/view/ViewExternalSubResourceProvider.java > f669e49 > > ambari-server/src/main/java/org/apache/ambari/server/view/ViewSubResourceProvider.java > 8e1ccbc > > ambari-server/src/test/java/org/apache/ambari/server/api/services/PersistenceManagerImplTest.java > 243e06a > > ambari-server/src/test/java/org/apache/ambari/server/controller/gsinstaller/GSInstallerClusterProviderTest.java > e4a595c > > ambari-server/src/test/java/org/apache/ambari/server/controller/gsinstaller/GSInstallerComponentProviderTest.java > 07ff7fe > > ambari-server/src/test/java/org/apache/ambari/server/controller/gsinstaller/GSInstallerHostComponentProviderTest.java > c9878f5 > > ambari-server/src/test/java/org/apache/ambari/server/controller/gsinstaller/GSInstallerHostProviderTest.java > 32b1250 > > ambari-server/src/test/java/org/apache/ambari/server/controller/gsinstaller/GSInstallerServiceProviderTest.java > 3fd4bd7 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AbstractJDBCResourceProviderTest.java > 0a5cfcc > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AbstractResourceProviderTest.java > 1731439 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ActiveWidgetLayoutResourceProviderTest.java > e9abfb3 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AlertDefinitionResourceProviderTest.java > 79d512a > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AlertGroupResourceProviderTest.java > eaf351d > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AlertTargetResourceProviderTest.java > 7277b67 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AmbariPrivilegeResourceProviderTest.java > 98494d8 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ArtifactResourceProviderTest.java > 33a228a > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintResourceProviderTest.java > 30e7c01 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProviderTest.java > e2146d0 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterControllerImplTest.java > 3f292ca > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterKerberosDescriptorResourceProviderTest.java > 2d72cb0 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterPrivilegeResourceProviderTest.java > bff15af > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterResourceProviderTest.java > 7292be2 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ComponentResourceProviderTest.java > 286b3cf > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ConfigGroupResourceProviderTest.java > 5b9785e > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ConfigurationResourceProviderTest.java > 6f7db80 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/CredentialResourceProviderTest.java > 31bf191 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/FeedResourceProviderTest.java > 39a0509 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/GroupPrivilegeResourceProviderTest.java > 205f467 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/GroupResourceProviderTest.java > 7d1bddf > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostComponentResourceProviderTest.java > a2e1fda > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostKerberosIdentityResourceProviderTest.java > 1b1b4ac > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostResourceProviderTest.java > c16013a > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/InstanceResourceProviderTest.java > 1a74ac3 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/LdapSyncEventResourceProviderTest.java > 8a12c13 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/MemberResourceProviderTest.java > 26a5cff > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/PermissionResourceProviderTest.java > fb4454e > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProviderTest.java > d07ed76 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RequestResourceProviderTest.java > ea4afde > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RequestScheduleResourceProviderTest.java > cb4d8aa > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RoleAuthorizationResourceProviderTest.java > 23afa8f > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/SchemaImplTest.java > 1c3d14a > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ServiceResourceProviderTest.java > e113347 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/SettingResourceProviderTest.java > c133220 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StageResourceProviderTest.java > 435587d > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/TargetClusterResourceProviderTest.java > 96c6db4 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/TaskResourceProviderTest.java > 587febe > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UserAuthorizationResourceProviderTest.java > c19e5ad > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UserPrivilegeResourceProviderTest.java > 28a061c > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UserResourceProviderTest.java > 3dd4ad2 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ViewInstanceResourceProviderTest.java > b384b8a > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/WidgetLayoutResourceProviderTest.java > 2f05402 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/WidgetResourceProviderTest.java > 8192f38 > > Diff: https://reviews.apache.org/r/46172/diff/ > > > Testing > ------- > > Unit tests > > > Thanks, > > Ajit Kumar > >
