> On April 18, 2016, 5:13 a.m., Jayush Luniya wrote:
> > ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms.py,
> > line 238
> > <https://reviews.apache.org/r/46016/diff/3/?file=1347599#file1347599line238>
> >
> > If a feature can be service config property driven do we really need to
> > add a stack-feature? Would "if params.enable_kms_hsm" check be sufficient?
It can be sufficient as I have handled it as enable_kms_hsm =
default("/configurations/dbks-site/ranger.ks.hsm.enabled", False).
I added a extra flag just to simplify implementation and ranger.ks.hsm.enabled
will only be available under stack-2.5 (Also Ranger KMS HSM is a new feature
in stack-2.5)
- Mugdha
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46016/#review129290
-----------------------------------------------------------
On April 16, 2016, 8:44 a.m., Mugdha Varadkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46016/
> -----------------------------------------------------------
>
> (Updated April 16, 2016, 8:44 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Jonathan
> Hurley, Jayush Luniya, and Velmurugan Periasamy.
>
>
> Bugs: AMBARI-15752
> https://issues.apache.org/jira/browse/AMBARI-15752
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Add HSM support configuration properties for Ranger KMS in hdp-2.5
>
>
> Diffs
> -----
>
>
> ambari-common/src/main/python/resource_management/libraries/functions/constants.py
> 86dbc48
>
> ambari-common/src/main/python/resource_management/libraries/functions/stack_features.py
> 7201c36
>
> ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms.py
> dd91acf
>
> ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/params.py
> fc722da
>
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json
> 03b7e01
>
> ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER_KMS/configuration/dbks-site.xml
> PRE-CREATION
>
> ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER_KMS/configuration/kms-env.xml
> PRE-CREATION
>
> ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER_KMS/metainfo.xml
> 02fb6aa
>
> ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER_KMS/themes/theme_version_2.json
> PRE-CREATION
>
> Diff: https://reviews.apache.org/r/46016/diff/
>
>
> Testing
> -------
>
> Installed Ranger KMS centos6.
>
>
> Thanks,
>
> Mugdha Varadkar
>
>
