----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46360/#review129516 -----------------------------------------------------------
Ship it! Ship It! - Robert Levas On April 18, 2016, 10:03 p.m., Tom Beerbower wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46360/ > ----------------------------------------------------------- > > (Updated April 18, 2016, 10:03 p.m.) > > > Review request for Ambari, John Speidel and Robert Levas. > > > Bugs: AMBARI-15939 > https://issues.apache.org/jira/browse/AMBARI-15939 > > > Repository: ambari > > > Description > ------- > > Use the stack advisor to suggest the correct configs for the Atlas > integrations if the Atlas service is installed. > > See AMBARI-14920. > > Also, minor refactoring to move integration specific work into separate > scripts. > > > Diffs > ----- > > > ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon.py > 46457ad > > ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/params_linux.py > 84d8b57 > > ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/setup_atlas_falcon.py > PRE-CREATION > > ambari-server/src/main/resources/common-services/SQOOP/1.4.4.2.0/configuration/sqoop-site.xml > dd299fe > > ambari-server/src/main/resources/common-services/SQOOP/1.4.4.2.0/package/scripts/params_linux.py > 7db974f > > ambari-server/src/main/resources/common-services/SQOOP/1.4.4.2.0/package/scripts/setup_atlas_sqoop.py > PRE-CREATION > > ambari-server/src/main/resources/common-services/SQOOP/1.4.4.2.0/package/scripts/sqoop.py > 1276a54 > > ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/configuration/storm-site.xml > cf702c0 > > ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/params_linux.py > 101ca46 > > ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/setup_atlas_storm.py > PRE-CREATION > > ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/storm.py > 74050d8 > > ambari-server/src/main/resources/stacks/HDP/2.2/services/FALCON/configuration/falcon-startup.properties.xml > 5d4fa1e > ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py > 66076f2 > ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py > 6c9fd46 > > Diff: https://reviews.apache.org/r/46360/diff/ > > > Testing > ------- > > Added unit tests for new stack advisor methods. > > mvn clean test > > > Thanks, > > Tom Beerbower > >
