----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46448/#review129757 -----------------------------------------------------------
Fix it, then Ship it! ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java (line 66) <https://reviews.apache.org/r/46448/#comment193293> Make this configurable maybe? If you disagree, you can drop this. ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java (line 1001) <https://reviews.apache.org/r/46448/#comment193294> Do we have a test for this? An error around cached values is a nightmare to debug. We should always ensure (via capturing in a test) that this method gets the latest, bypassing the cache - Jonathan Hurley On April 20, 2016, 1:07 p.m., Dmitro Lisnichenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46448/ > ----------------------------------------------------------- > > (Updated April 20, 2016, 1:07 p.m.) > > > Review request for Ambari, Jonathan Hurley and Vitalyi Brodetskyi. > > > Bugs: AMBARI-15994 > https://issues.apache.org/jira/browse/AMBARI-15994 > > > Repository: ambari > > > Description > ------- > > STR: > -Change zookeeper property "Length of single tick" from UI > > This test changed the property Length of single tick from 2000 to 2001 for > Zookeeper. This should have restart indicators for Zookeeper, Storm and > Kafka. As seen from the UI, all the services had restart icons appearing late. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java > 8d9a879 > ambari-server/src/main/java/org/apache/ambari/server/state/Host.java > fce2f91 > > ambari-server/src/main/java/org/apache/ambari/server/state/host/HostImpl.java > 0514720 > > Diff: https://reviews.apache.org/r/46448/diff/ > > > Testing > ------- > > mvn clean test > > > Thanks, > > Dmitro Lisnichenko > >
