-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46451/
-----------------------------------------------------------

Review request for Ambari, Andrew Onischuk, Jayush Luniya, Jonathan Maron, and 
Tom Beerbower.


Bugs: AMBARI-15989
    https://issues.apache.org/jira/browse/AMBARI-15989


Repository: ambari


Description
-------

```
INFO 2016-04-20 01:23:58,838 PythonReflectiveExecutor.py:64 - Reflective 
command failed with exception:
Traceback (most recent call last):
  File 
"/usr/lib/python2.6/site-packages/ambari_agent/PythonReflectiveExecutor.py", 
line 56, in run_file
    imp.load_source('__main__', script)
  File 
"/var/lib/ambari-agent/cache/common-services/ATLAS/0.1.0.2.3/package/scripts/metadata_server.py",
 line 132, in <module>
    MetadataServer().execute()
  File 
"/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py",
 line 219, in execute
    method(env)
  File 
"/var/lib/ambari-agent/cache/common-services/ATLAS/0.1.0.2.3/package/scripts/metadata_server.py",
 line 99, in security_status
    {'application.properties': FILE_TYPE_PROPERTIES})
  File 
"/usr/lib/python2.6/site-packages/resource_management/libraries/functions/security_commons.py",
 line 141, in get_params_from_filesystem
    config.readfp(ini_fp)
  File "/usr/lib64/python2.7/ConfigParser.py", line 324, in readfp
    self._read(fp, filename)
  File "/usr/lib64/python2.7/ConfigParser.py", line 546, in _read
    raise e
ParsingError: File contains parsing errors: <???>
        [line 38]: 'DEFAULT\n'
INFO 2016-04-20 01:24:07,618 Heartbeat.py:78 - Building Heartbeat: {responseId 
= 97, timestamp = 1461115447618, commandsInProgress = False, componentsMapped = 
True}
```

# Cause
The issue has to do with the python built-in ConfigParser.  It fails to parse 
multi-lined property vales unless there is a space added to the beginning of 
the additional lines

# Solution
Fix the call to the ConfigParser to add the missing spaces (for internal use 
only).  The data in the relevant config files are not altered
While making changes fix the logic in the Atlas security_status method to 
properly determine security status.


Diffs
-----

  
ambari-common/src/main/python/resource_management/libraries/functions/security_commons.py
 47bcee0 
  
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/configuration/application-properties.xml
 a6deda1 
  
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/kerberos.json 
087fc93 
  
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/metadata_server.py
 a5990a2 
  
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/params.py
 3443016 
  ambari-server/src/test/python/stacks/2.3/ATLAS/test_metadata_server.py 
fd3ca81 
  ambari-server/src/test/resources/kerberos/test_kerberos_descriptor_2_1_3.json 
f3dbd38 

Diff: https://reviews.apache.org/r/46451/diff/


Testing
-------

Manually tested in cluster

# Local test results: PASSED

# Jenkins test results: PENDING


Thanks,

Robert Levas

Reply via email to