This is an automatically generated e-mail. To reply, visit:

(Updated April 20, 2016, 8:25 p.m.)

Review request for Ambari, Jonathan Robie, Nate Cole, and Nahappan Somasundaram.


1. Quartz tables were not touched in the 2nd patch (except in the Derby DDL 
which contained bad column names)
2. Only PK's are named, other unnamed constraints remained as is (according to 
discussion with Jonathan)
3. In cases where there were missing columns/constraints, the Postgres DDL was 
taken as master.
4. I Changed the constraint naming algorithm: names were only shortened if they 
hit Oracle's 30 character limit.
5. Tests were updated.
6. Test run result: all Java unit tests passed in ambari-server.

Bugs: AMBARI-15915

Repository: ambari


1. Inlined alter table statements (except one to overcome a circular FK 
2. Reorganized create table statemens to avoid forward references
3. Named all unnamed constraints, shortened names to fit Oracle's 30 character 
4. Unified constraint names across database flavors
5. Wrote a JUnit test that checks DDL's for consistency (all constraints are 
named, the same tables and constraints are defined for all database flavors)

Diffs (updated)

  ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql f90ac96 
  ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 2b214c4 
  ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql fc93372 
  ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 870a8e8 
  ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 6e600c7 
  ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql a3ea10d 

Diff: https://reviews.apache.org/r/46269/diff/


1. Run all java unit tests in ambari-server. All passed, except 
ViewDirectoryWatcherTest.testDirectoryExtractionOnFileAdd(). Failure occured to 
a hardcoded timeout value in the test being to low for my environment (I raised 
the timeout from 7 secs to 20 and the test passed)
2. Run DDL's with their respective DB environment. In cases where the DDL 
contained additional things other than table/index cration and insertion (e.g. 
creating databases and users) I only run the table/index creation part.


Balázs Bence Sári

Reply via email to