> On 4月 21, 2016, 12:25 a.m., Masahiro Tanaka wrote:
> > Thanks for the review Nate and Andrew!
> > Could you commit this?
> 
> Andrew Onischuk wrote:
>     before we can commit we need an apache jira for this change, and +1 from 
> Hadoop QA. 
>     
>     Do you have one? If yes specify its id in "Bugs" field here.
> 
> Masahiro Tanaka wrote:
>     I forgot to add the jira number... I'm sorry.
> 
> Andrew Onischuk wrote:
>     no worries
> 
> Andrew Onischuk wrote:
>     Thanks for the contribution! Committed the patch to trunk. Please feel 
> free to close this review.

thank you!


- Masahiro


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45998/#review129845
-----------------------------------------------------------


On 4月 21, 2016, 10:30 a.m., Masahiro Tanaka wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45998/
> -----------------------------------------------------------
> 
> (Updated 4月 21, 2016, 10:30 a.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Jaimin Jetly, and Nate Cole.
> 
> 
> Bugs: AMBARI-15792
>     https://issues.apache.org/jira/browse/AMBARI-15792
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> In templetonSmoke.sh, there are
> 1) unnecessary `exit 0`
> 2) lack of redirect `>` command
> 3) unassigned variable
> 
> we should correct them all to check the HIVE service properly.
> 
> 
> Diffs
> -----
> 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/files/templetonSmoke.sh
>  dd00e02 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_service_check.py
>  9965bfa9 
>   ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_service_check.py 
> 6c4dc00 
> 
> Diff: https://reviews.apache.org/r/45998/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test and manual test with HDP2.4 and Ambari 2.2.1.0
> 
> 
> Thanks,
> 
> Masahiro Tanaka
> 
>

Reply via email to