> On April 22, 2016, 5:58 p.m., Jayush Luniya wrote:
> > ambari-server/src/main/resources/stacks/stack_advisor.py, line 473
> > <https://reviews.apache.org/r/44210/diff/2/?file=1348350#file1348350line473>
> >
> > I might be missing something, but it doesnt look like we are using
> > getHostsForSlaveComponent
Yep I missed something in that patch, when I updated an older patch over some
later code. The createComponentLayoutRecommendations code should have the
client/slave section like this:
for service in services["services"]:
slaveClientComponents = [component for component in service["components"]
if self.isSlaveComponent(component) or
self.isClientComponent(component)]
serviceAdvisor = self.createServiceAdvisor(service)
for component in slaveClientComponents:
componentName = component["StackServiceComponents"]["component_name"]
hostsForComponent = []
if serviceAdvisor is None:
hostsForComponent = self.getHostsForSlaveComponent(services, hosts,
component, hostsList, hostsComponentsMap)
else:
hostsForComponent = serviceAdvisor.getHostsForSlaveComponent(self,
services, hosts, component, hostsList, hostsComponentsMap)
- Tim
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44210/#review130138
-----------------------------------------------------------
On April 22, 2016, 4:39 p.m., Tim Thorpe wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44210/
> -----------------------------------------------------------
>
> (Updated April 22, 2016, 4:39 p.m.)
>
>
> Review request for Ambari, Jayush Luniya, Sumit Mohanty, Srimanth Gunturi,
> and Yusaku Sako.
>
>
> Bugs: AMBARI-15226
> https://issues.apache.org/jira/browse/AMBARI-15226
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Currently the stack advisor is defined under each stack version such as
> HDP/2.3. The problem with this is that it restricts the services that can be
> added to the stack. If a custom service is to be added, they would need to
> modify the stack advisor. If the configuration recommendation and validation
> can be done at the service level then the custom service could just include
> their own recommendations and validations separately.
>
>
> Diffs
> -----
>
> ambari-server/src/main/assemblies/server.xml e1a4919
>
> ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java
> df65010
>
> ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/commands/StackAdvisorCommand.java
> 00c8696
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/StackServiceResponse.java
> ca1968e
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackServiceResourceProvider.java
> 6c6fa91
>
> ambari-server/src/main/java/org/apache/ambari/server/stack/CommonServiceDirectory.java
> 636de37
>
> ambari-server/src/main/java/org/apache/ambari/server/stack/ServiceDirectory.java
> d574d60
>
> ambari-server/src/main/java/org/apache/ambari/server/stack/ServiceModule.java
> b7e09a9
>
> ambari-server/src/main/java/org/apache/ambari/server/stack/StackServiceDirectory.java
> d27e52a
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceInfo.java
> db95fec
>
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/service_advisor.py
> PRE-CREATION
>
> ambari-server/src/main/resources/common-services/PXF/3.0.0/service_advisor.py
> PRE-CREATION
> ambari-server/src/main/resources/properties.json eac0dbd
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py
> 0130483
> ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py
> 3a65541
> ambari-server/src/main/resources/stacks/service_advisor.py PRE-CREATION
> ambari-server/src/main/resources/stacks/stack_advisor.py 539bd25
> ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py
> 6c9fd46
>
> Diff: https://reviews.apache.org/r/44210/diff/
>
>
> Testing
> -------
>
> Ran all the non java unit tests.
>
> Total run:945
> Total errors:0
> Total failures:0
>
> Manually configured HAWQ and PXF as part of the HDP 2.3 stack and made sure
> their service advisors were called.
>
>
> Thanks,
>
> Tim Thorpe
>
>
