> On April 20, 2016, 8:03 a.m., Jayush Luniya wrote:
> > Ship It!
> 
> Masahiro Tanaka wrote:
>     Thank you, could you commit this?
> 
> Jayush Luniya wrote:
>     Ok will commit today.

Committed. Can you please close the review?


- Jayush


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45676/#review129706
-----------------------------------------------------------


On April 22, 2016, 9:35 a.m., Masahiro Tanaka wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45676/
> -----------------------------------------------------------
> 
> (Updated April 22, 2016, 9:35 a.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Jaimin Jetly, jun aoki, Jayush 
> Luniya, and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-15678
>     https://issues.apache.org/jira/browse/AMBARI-15678
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> If yarn app state is not state or yarn app finalStatus is not succeeded, YARN 
> service check should fail.
> But in the YARN service_check.py, it doesn't fail because raise statement is 
> in try block and there is only `pass` in except block.
> 
> 
> Diffs
> -----
> 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/service_check.py
>  e8d98ab 
> 
> Diff: https://reviews.apache.org/r/45676/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Masahiro Tanaka
> 
>

Reply via email to