----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46547/#review130209 -----------------------------------------------------------
Ship it! LGTM. - Swapan Shridhar On April 22, 2016, 10:24 p.m., Alejandro Fernandez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46547/ > ----------------------------------------------------------- > > (Updated April 22, 2016, 10:24 p.m.) > > > Review request for Ambari, Siddharth Seth and Swapan Shridhar. > > > Bugs: AMBARI-16031 > https://issues.apache.org/jira/browse/AMBARI-16031 > > > Repository: ambari > > > Description > ------- > > - In non-kerberized cluster, hive.llap.daemon.work.dir will point to : > "${yarn.nodemanager.local-dirs}” > - In kerberized cluster, we need to create "/hadoop/llap/local" on each node > and disk and have "hive.llap.daemon.work.dirs" point to it. > - It's similar to the way yarn.nodemanager.local-dirs is created. > > > Diffs > ----- > > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/kerberos.json > 872bfac > > ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/metainfo.xml > 10e6405 > > ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/nodemanager.py > 6837c27 > > ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py > 19dbb60 > > ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/yarn.py > 735d8cb > ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/kerberos.json > a03a1b7 > ambari-web/app/controllers/main/service/item.js 5707882 > ambari-web/app/messages.js 6c0049d > ambari-web/app/models/host_component.js b4a369e > ambari-web/app/views/main/service/item.js 51f9bdd > ambari-web/test/views/main/service/item_test.js 085eaad > > Diff: https://reviews.apache.org/r/46547/diff/ > > > Testing > ------- > > Verified on cluster with HDP 2.4, Hive Server Interactive + LLAP, and then > kerberized. > > Python unit tests passed, > ---------------------------------------------------------------------- > Total run:976 > Total errors:0 > Total failures:0 > OK > > on ambari-web, mvn test passed, > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 39.952 s > [INFO] Finished at: 2016-04-21T15:55:34-07:00 > [INFO] Final Memory: 36M/3926M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Alejandro Fernandez > >
