-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46600/#review130264
-----------------------------------------------------------




ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py
 (line 210)
<https://reviews.apache.org/r/46600/#comment193990>

    Should slider_am_container_mb be params.slider_am_container_mb?



ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py (line 
173)
<https://reviews.apache.org/r/46600/#comment193991>

    Impressive set of calculations. Can we add unit tests for these?


- Sumit Mohanty


On April 23, 2016, 10:34 a.m., Swapan Shridhar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46600/
> -----------------------------------------------------------
> 
> (Updated April 23, 2016, 10:34 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-16078.patch
>     https://issues.apache.org/jira/browse/AMBARI-16078.patch
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Fix for : 
>   (1). AMBARI-16078. Config calculations used by LLAP app. 
>   (2). AMBARI-16079. waiting for fixed number of times if the launched LLAP 
> app is in LAUNCHING state, for it to go to RUNNING_ALL or RUNNING_PARTIAL
> 
> AMBARI-16078:
> ============
> - Calculated in Stack advisor code whenever (1). HSI is enabled, or (2). 
> change done to slider HSI slider "% of Cluster Capacity" , or (3). change 
> done to slider HSI slider 'Number of Daemon Instances'
> - 
> - caluclations are not done if the overall cluster state is not conduciv for 
> meaningful run of LLAP.
> 
> AMBARI-16079: 
> =============
> 
> Reason : If the LLAP app state is LAUNCHING and we go ahead with HSI start, 
> the overall workability of app may not be ascertained.
> As of now, using llap0 name, app does go into RUNNING_ALL state.
> 
> 
> Diffs
> -----
> 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py
>  f548ea3 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
>  a044fda 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-interactive-env.xml
>  816e207 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-interactive-site.xml
>  21d1109 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
> 4da21fa 
>   ambari-server/src/test/python/stacks/2.5/HIVE/test_hive_server_int.py 
> 44759a9 
>   ambari-server/src/test/python/stacks/2.5/configs/hsi_default.json 1cb2a02 
> 
> Diff: https://reviews.apache.org/r/46600/diff/
> 
> 
> Testing
> -------
> 
> Python UT passes.
> 
> 
> Thanks,
> 
> Swapan Shridhar
> 
>

Reply via email to