-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46614/#review130403
-----------------------------------------------------------


Fix it, then Ship it!





ambari-server/src/main/java/org/apache/ambari/server/upgrade/AbstractUpgradeCatalog.java
 (lines 205 - 206)
<https://reviews.apache.org/r/46614/#comment194151>

    This is pretty generic and can be named isConfigEnabled(cluster, 
configType, property)
    
    I agree that it's a bit odd that we have service specific calls in the base 
class, but it's not terrible either.  Maybe see how isRangerKnoxPluginEnabled() 
is used and switch to the more generic function if it's easy enough.


- Nate Cole


On April 24, 2016, 2:55 p.m., Dmitro Lisnichenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46614/
> -----------------------------------------------------------
> 
> (Updated April 24, 2016, 2:55 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Nate Cole, and Velmurugan 
> Periasamy.
> 
> 
> Bugs: AMBARI-16084
>     https://issues.apache.org/jira/browse/AMBARI-16084
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> So here's where we are:
> 
> - https://reviews.apache.org/r/45890/diff/2#index_header removed hard-coded 
> python code which was trying to figure out which coprocessor to use. With 
> these values gone, it's now up to Ambari to set the _right_ value in the 
> configurations.
> 
> - However, after removing the above code, we never change the ranger 
> configurations to reflect the proper value
> 
> - To fix this, we need to fix the values on Ambari upgrade. When upgrading 
> Ambari from 2.0, we'll need to do the following:
> -- If Ranger is disabled; do nothing
> -- If Ranger is enabled and the cluster's current stack is HDP 2.2, then set 
> the master/region coprocessors to
> {code}
> hbase_coprocessor_master_classes = 
> "com.xasecure.authorization.hbase.XaSecureAuthorizationCoprocessor"
> hbase_coprocessor_regionserver_classes = 
> "com.xasecure.authorization.hbase.XaSecureAuthorizationCoprocessor"
> hbase_coprocessor_region_classes = 
> "org.apache.hadoop.hbase.security.token.TokenProvider,org.apache.hadoop.hbase.security.access.SecureBulkLoadEndpoint,com.xasecure.authorization.hbase.XaSecureAuthorizationCoprocessor"
> {code}
> -- If Ranger is enabled and the cluster's current stack is HDP 2.3, then set 
> the master/region coprocessors to
> {code}
> hbase_coprocessor_master_classes = 
> "org.apache.ranger.authorization.hbase.RangerAuthorizationCoprocessor "
> hbase_coprocessor_regionserver_classes = 
> "org.apache.ranger.authorization.hbase.RangerAuthorizationCoprocessor"
> hbase_coprocessor_region_classes = 
> "org.apache.hadoop.hbase.security.token.TokenProvider,org.apache.hadoop.hbase.security.access.SecureBulkLoadEndpoint,org.apache.ranger.authorization.hbase.RangerAuthorizationCoprocessor"
> {code}
> 
> Now HDP stack upgrades will work since we look for 
> {{XaSecureAuthorizationCoprocessor}} and change it to 
> {{RangerAuthorizationCoprocessor}} as needed.
> 
> 
> Diffs
> -----
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/AbstractUpgradeCatalog.java
>  b7665ce 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog222.java
>  31a3ce5 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog222Test.java
>  4302349 
> 
> Diff: https://reviews.apache.org/r/46614/diff/
> 
> 
> Testing
> -------
> 
> unit tests in progress
> 
> live cluster check in progress
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>

Reply via email to