> On April 20, 2016, 9:46 a.m., Alexandr Antonenko wrote:
> > Ship It!
> 
> Anita Jebaraj wrote:
>     Can you please push the code to trunk, I don't have the priviledge for 
> that.

yes, ofc


- Alexandr


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46398/#review129717
-----------------------------------------------------------


On April 19, 2016, 6:20 p.m., Anita Jebaraj wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46398/
> -----------------------------------------------------------
> 
> (Updated April 19, 2016, 6:20 p.m.)
> 
> 
> Review request for Ambari, Alexandr Antonenko and Di Li.
> 
> 
> Bugs: ambari-15869
>     https://issues.apache.org/jira/browse/ambari-15869
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Click Alerts at the top
> The Click Actions -> select Manage Notifications
> Click on the + icon, the create Alert notification pop up will be displayed.
> Currently the notification name allows all characters, it should be 
> restricted to allow only alphanumberics, spaces, hyphens and underscores.
> 
> 
> Diffs
> -----
> 
>   
> ambari-web/app/controllers/main/alerts/manage_alert_notifications_controller.js
>  7dd7dea 
>   ambari-web/app/messages.js 3ede13a 
>   ambari-web/app/utils/validator.js 6426163 
>   
> ambari-web/test/controllers/main/alerts/manage_alert_notifications_controller_test.js
>  837c2f3 
> 
> Diff: https://reviews.apache.org/r/46398/diff/
> 
> 
> Testing
> -------
> 
> Ran mvn clean test 
>   25660 tests complete (29 seconds)
>   154 tests pending
> 
> 
> Thanks,
> 
> Anita Jebaraj
> 
>

Reply via email to