-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46600/
-----------------------------------------------------------

(Updated April 25, 2016, 11:37 p.m.)


Review request for Ambari, Alejandro Fernandez and Sumit Mohanty.


Changes
-------

Added Sid's suggestions and fixed few corener cases.


Bugs: AMBARI-16078, AMBARI-16079, AMBARI-16086, and AMBARI-16087
    https://issues.apache.org/jira/browse/AMBARI-16078
    https://issues.apache.org/jira/browse/AMBARI-16079
    https://issues.apache.org/jira/browse/AMBARI-16086
    https://issues.apache.org/jira/browse/AMBARI-16087


Repository: ambari


Description
-------

Fix for : 
  (1). AMBARI-16078. Config calculations used by LLAP app. 
  
  Trivial fixes for :
  
   (2). AMBARI-16079. waiting for fixed number of times if the launched LLAP 
app is in LAUNCHING state, for it to go to RUNNING_ALL or RUNNING_PARTIAL
  (3). AMBARI-16086. Hide HSI related sliders when 'llap' queue is not being 
used.
  (4). AMBARI-16087. LLAP queue is not selected when enabling Hive Interactive 
Query during Install Wizard

AMBARI-16078:
============
- Calculated in Stack advisor code whenever : LLAP queue is in selection and 
(1). HSI is enabled or (2). change done to slider HSI slider "% of Cluster 
Capacity" , or (3). change done to slider HSI slider 'Number of Daemon 
Instances'
- 
- caluclations are not done if the overall cluster state is not conduciv for 
meaningful run of LLAP.

AMBARI-16079: 
=============

Reason : If the LLAP app state is LAUNCHING and we go ahead with HSI start, the 
overall workability of app may not be ascertained.
As of now, using llap0 name, app does go into RUNNING_ALL state.


Diffs (updated)
-----

  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py
 f548ea3 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
 a044fda 
  
ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-interactive-env.xml
 816e207 
  
ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-interactive-site.xml
 21d1109 
  
ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/themes/theme.json 
4e1a54b 
  ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
4da21fa 
  ambari-server/src/test/python/stacks/2.5/HIVE/test_hive_server_int.py 44759a9 
  ambari-server/src/test/python/stacks/2.5/common/test_stack_advisor.py 3934301 
  ambari-server/src/test/python/stacks/2.5/configs/hsi_default.json 1cb2a02 

Diff: https://reviews.apache.org/r/46600/diff/


Testing
-------

- Python tests added.
- Python UT passes.


----------------------------------------------------------------------
Ran 261 tests in 7.091s

OK
----------------------------------------------------------------------
Total run:995
Total errors:0
Total failures:0
OK


Thanks,

Swapan Shridhar

Reply via email to