-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46649/#review130559
-----------------------------------------------------------


Ship it!




Ship It!

- Dmitro Lisnichenko


On April 25, 2016, 9:05 p.m., Dmytro Sen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46649/
> -----------------------------------------------------------
> 
> (Updated April 25, 2016, 9:05 p.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Dmitro Lisnichenko, and Vitalyi 
> Brodetskyi.
> 
> 
> Bugs: AMBARI-16100
>     https://issues.apache.org/jira/browse/AMBARI-16100
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> UpgradeCatalog220#updateKerberosDescriptorArtifact
>             KerberosIdentityDescriptor hdfsIdentity = 
> hdfsService.getIdentity("hdfs");
>             KerberosComponentDescriptor namenodeComponent = 
> hdfsService.getComponent("NAMENODE");
>             hdfsIdentity.setName("hdfs");
>             hdfsService.removeIdentity("hdfs");
> in case of second run on same database we will have here NPE, coz that 
> descriptor was already removed. Before using him, we need check that 
> descriptor is present and is not null
> 
> 
> Diffs
> -----
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog220.java
>  0eef4f1 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog220Test.java
>  99cabfa 
> 
> Diff: https://reviews.apache.org/r/46649/diff/
> 
> 
> Testing
> -------
> 
> Unit tests passed
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>

Reply via email to