----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46689/#review130581 -----------------------------------------------------------
contrib/views/pig/src/main/java/org/apache/ambari/view/pig/resources/files/FileService.java (line 207) <https://reviews.apache.org/r/46689/#comment194416> Possible NPE if filepath is null, I am not sure if this is ever possible. just double check this - Ashwin Rajeev On April 26, 2016, 9:55 a.m., Gaurav Nagar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46689/ > ----------------------------------------------------------- > > (Updated April 26, 2016, 9:55 a.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Nitiraj Rathore, Pallav > Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev. > > > Bugs: AMBARI-16116 > https://issues.apache.org/jira/browse/AMBARI-16116 > > > Repository: ambari > > > Description > ------- > > Added check for filepath to start with '/' > > > Diffs > ----- > > > contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/files/FileService.java > 3eac2b7 > > contrib/views/pig/src/main/java/org/apache/ambari/view/pig/resources/files/FileService.java > 6697160 > > Diff: https://reviews.apache.org/r/46689/diff/ > > > Testing > ------- > > Manual Testing > > > Thanks, > > Gaurav Nagar > >