> On April 26, 2016, 9:14 a.m., Robert Levas wrote:
> > ambari-common/src/main/python/resource_management/libraries/functions/curl_krb_request.py,
> >  lines 183-206
> > <https://reviews.apache.org/r/46619/diff/2/?file=1361521#file1361521line183>
> >
> >     This is closer, but I expected to see something like:
> >     
> >     ```
> >     curl_command = ['curl', '-L', '-k', '--negotiate', '-u', ':', '-b', 
> > cookie_file, '-c', cookie_file, '--connect-timeout', 
> > str(connection_timeout), '--max-time', str(maximum_timeout)]
> >     
> >     if ....
> >       curl_command.extend([...])
> >     elif ...
> >       curl_command.extend([...])
> >     else 
> >       curl_command.extend([...])
> >     
> >     curl_command.append(url)
> >     _, curl_stdout, curl_stderr = get_user_call_output(curl_command, 
> > user=user, env=kerberos_env)
> >           ```

+1 for this suggestion


- Nate


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46619/#review130602
-----------------------------------------------------------


On April 26, 2016, 8:18 a.m., Gautam Borad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46619/
> -----------------------------------------------------------
> 
> (Updated April 26, 2016, 8:18 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Mahadev Konar, 
> Nate Cole, Robert Levas, Sumit Mohanty, and Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-16085
>     https://issues.apache.org/jira/browse/AMBARI-16085
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> **Problem Statement**
> In order to allow Ranger plugins to support Kerberos Authentication, make 
> changes in Ranger plugin stacks to create ranger services and policies using 
> component principal / keytab. Also take care of config changes to support 
> plugin communication in Kerberos enabled env.
> 
> **Proposed Solution**
> Update Ranger repository creation calls to use component principal/keytab as 
> well as update config parameters to support Ranger plugin communication.
> 
> 
> Diffs
> -----
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/curl_krb_request.py
>  cf0d5a6 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/ranger_functions_v2.py
>  3bb0103 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/setup_ranger_plugin_xml.py
>  a7faf3b 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py
>  2c466ea 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/setup_ranger_hbase.py
>  ffd0715 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py
>  e6fd32c 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/setup_ranger_hdfs.py
>  858044c 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
>  aa561f8 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/setup_ranger_hive.py
>  f51dbab 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.8.1.2.2/package/scripts/params.py
>  d4ee6f9 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.8.1.2.2/package/scripts/setup_ranger_kafka.py
>  a99dc76 
>   
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py
>  d572aff 
>   
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/setup_ranger_knox.py
>  13987c8 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/params_linux.py
>  3f9b936 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/setup_ranger_storm.py
>  bef1f02 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py
>  8fbefb2 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/setup_ranger_yarn.py
>  21fe8e1 
> 
> Diff: https://reviews.apache.org/r/46619/diff/
> 
> 
> Testing
> -------
> 
> **Verified**
> Added Ranger in a Kerberos enabled environment and verified enable of plugin 
> for supported components.
> 
> 
> Thanks,
> 
> Gautam Borad
> 
>

Reply via email to