> On April 4, 2016, 9:05 a.m., Sreenath Somarajapuram wrote: > > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched.hbs, > > line 28 > > <https://reviews.apache.org/r/44704/diff/1/?file=1295731#file1295731line28> > > > > Whay are we having an anchor tags inside link-to? And what is the > > purpose fo href="view.href". > > Akhil PB wrote: > Here link-to tag is li, not anchor. When link-to is clicked, ember would > add active class to link-to element. Since we have tab structure, I have used > this to show active tab whenever user clicks on tab. > Please refer > http://stackoverflow.com/questions/11628489/emberjs-how-to-mark-active-menu-item-using-router-infrastructure
Rewrote as <a href="#">Scheduler</a> - Akhil ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44704/#review126795 ----------------------------------------------------------- On April 26, 2016, 10:43 a.m., Akhil PB wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44704/ > ----------------------------------------------------------- > > (Updated April 26, 2016, 10:43 a.m.) > > > Review request for Ambari and Sreenath Somarajapuram. > > > Bugs: AMBARI-15384 > https://issues.apache.org/jira/browse/AMBARI-15384 > > > Repository: ambari > > > Description > ------- > > Revamping the old capsched UI into new better one > > > Diffs > ----- > > contrib/views/capacity-scheduler/src/main/resources/ui/app/components.js > ac679b7 > > contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueHierarchy.js > PRE-CREATION > > contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueMapping.js > PRE-CREATION > > contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueSummary.js > PRE-CREATION > contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers.js > 16b7d0a > > contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/advanced.js > PRE-CREATION > > contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/capsched.js > PRE-CREATION > > contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/editqueue.js > PRE-CREATION > > contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/queuesconf.js > PRE-CREATION > > contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/scheduler.js > PRE-CREATION > contrib/views/capacity-scheduler/src/main/resources/ui/app/helpers.js > PRE-CREATION > > contrib/views/capacity-scheduler/src/main/resources/ui/app/helpers/queueMappingParser.js > PRE-CREATION > > contrib/views/capacity-scheduler/src/main/resources/ui/app/helpers/uppercase.js > PRE-CREATION > contrib/views/capacity-scheduler/src/main/resources/ui/app/initialize.js > 05bb64c > contrib/views/capacity-scheduler/src/main/resources/ui/app/router.js > a2d50b9 > > contrib/views/capacity-scheduler/src/main/resources/ui/app/styles/application.less > be79229 > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates.js > 25e2aa9 > > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched.hbs > PRE-CREATION > > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/advanced.hbs > PRE-CREATION > > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/accessControlList.hbs > PRE-CREATION > > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/editQueueCapacity.hbs > PRE-CREATION > > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/queueCapacity.hbs > PRE-CREATION > > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/queueResources.hbs > PRE-CREATION > > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/queuesconf.hbs > PRE-CREATION > > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/queuesconf/editqueue.hbs > PRE-CREATION > > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/scheduler.hbs > PRE-CREATION > > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/queueHierarchy.hbs > PRE-CREATION > > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/queueMapping.hbs > PRE-CREATION > > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/queueSummary.hbs > PRE-CREATION > > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/versionsPanel.hbs > PRE-CREATION > > contrib/views/capacity-scheduler/src/main/resources/ui/app/views/editQueueCapacity.js > PRE-CREATION > > contrib/views/capacity-scheduler/src/main/resources/ui/app/views/editqueue.js > PRE-CREATION > > contrib/views/capacity-scheduler/src/main/resources/ui/app/views/queuesconf.js > PRE-CREATION > > Diff: https://reviews.apache.org/r/44704/diff/ > > > Testing > ------- > > Manual unit testing > > > Thanks, > > Akhil PB > >
