-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46709/
-----------------------------------------------------------
(Updated April 27, 2016, 1:49 p.m.)
Review request for Ambari, Don Bosco Durai, Oliver Szabo, and Sumit Mohanty.
Changes
-------
Updated patch, since changes needed to be rebased on latest trunk.
Bugs: AMBARI-16129
https://issues.apache.org/jira/browse/AMBARI-16129
Repository: ambari
Description
-------
This patch resolves AMBARI-16129.
In that issue, it was noticed that the LogSearch integration would sometimes
return incorrect information for a given component/host combination. This was
caused by the fact that the LogSearch integration was using the "host" query
parameter, when in fact "host_name" is the parameter expected by LogSearch. In
addition, the "components_name" LogSearch parameter was renamed to
"component_name".
This patch implements the following:
1. Refactors the usage of the LogSearch-specific query parameters, such that
these parameters are only used within the LoggingRequestHelperImpl. This should
make maintaining this code simpler over time, since it essentially hides the
details of the LogSearch query paramter names.
2. Moved the method to create the log file tail URI to the LoggingRequestHelper
interface, to allow the details of this URI creation to be encapsulated within
the LoggingRequestHelper implementation (including the query parameter names
used).
3. Added javadoc on the LoggingRequestHelper interface.
4. Added a new unit test to verify this change, and updated existing unit tests
to accomodate this change as well.
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/logging/LoggingRequestHelper.java
eb45c9e
ambari-server/src/main/java/org/apache/ambari/server/controller/logging/LoggingRequestHelperImpl.java
c1afce0
ambari-server/src/main/java/org/apache/ambari/server/controller/logging/LoggingSearchPropertyProvider.java
f80bc6d
ambari-server/src/test/java/org/apache/ambari/server/controller/logging/LoggingRequestHelperImplTest.java
0a7e8f2
ambari-server/src/test/java/org/apache/ambari/server/controller/logging/LoggingSearchPropertyProviderTest.java
0d61984
Diff: https://reviews.apache.org/r/46709/diff/
Testing
-------
1. Deployed a 3-node vagrant cluster successfully with LogSearch enabled.
Verified that the log file tail URIs generated are using the new query
parameter names, and that these query URIs work properly when executed against
Ambari's REST interface.
2. Deployed a 3-node vagrant cluster successfully without LogSearch enabled.
Verified that no LogSearch-related logging or errors appear in
ambari-server.log or ambari-server.out.
3. Ran the ambari-server "mvn clean test" suite with my changes applied, with
the suite passing completely.
Thanks,
Robert Nettleton
