-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46745/#review130833
-----------------------------------------------------------




ambari-agent/src/main/package/deb/control/preinst (line 45)
<https://reviews.apache.org/r/46745/#comment194732>

    According to your comments, it is already backing up 
/var/lib/ambari-agent/cache, so why does a subdirectory need to be backuped too?


- Alejandro Fernandez


On April 27, 2016, 6:19 p.m., Di Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46745/
> -----------------------------------------------------------
> 
> (Updated April 27, 2016, 6:19 p.m.)
> 
> 
> Review request for Ambari and Alejandro Fernandez.
> 
> 
> Bugs: AMBARI-16140
>     https://issues.apache.org/jira/browse/AMBARI-16140
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> When a user runs yum upgrade ambari-agent. The preinstall script backs up the 
> stack dir in /var/lib/ambari-agent/cache by renaming it with a stampstamp. 
> The same logic should happen for /var/lib/ambari-agent/cache/common-services.
> 
> 
> Diffs
> -----
> 
>   ambari-agent/src/main/package/deb/control/preinst 7265c55 
>   ambari-agent/src/main/package/rpm/preinstall.sh d7419d3 
> 
> Diff: https://reviews.apache.org/r/46745/diff/
> 
> 
> Testing
> -------
> 
> build ambari-agent RPM, run yum upgrade ambari-agent against a trunk cluster, 
> verify /var/lib/ambari-agent/cache/stack and 
> /var/lib/ambari-agent/cache/common-services are backed up.
> 
> 
> Thanks,
> 
> Di Li
> 
>

Reply via email to