-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46751/#review130880
-----------------------------------------------------------




ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/timeline/AMSPropertyProvider.java
 (line 209)
<https://reviews.apache.org/r/46751/#comment194806>

    should the change be conditional - for FS that can provide high throughput 
we have not had the need for these changes. IOW, what are the downside of these 
changes?



ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/timeline/cache/TimelineMetricCache.java
 (line 70)
<https://reviews.apache.org/r/46751/#comment194805>

    How long before timeout is hit?



ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/timeline/cache/TimelineMetricCacheEntryFactory.java
 (line 92)
<https://reviews.apache.org/r/46751/#comment194804>

    Typically how long is the delay after which it will throw the exception.


- Sumit Mohanty


On April 27, 2016, 9:47 p.m., Sid Wagle wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46751/
> -----------------------------------------------------------
> 
> (Updated April 27, 2016, 9:47 p.m.)
> 
> 
> Review request for Ambari, Aravindan Vijayan, Dmytro Sen, Jonathan Hurley, 
> and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-16143
>     https://issues.apache.org/jira/browse/AMBARI-16143
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> In case of a SocketTimeoutException skip populating the resource with metrics 
> until the next retry.
> 
> 
> Diffs
> -----
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/timeline/AMSPropertyProvider.java
>  939ee7f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/timeline/AMSReportPropertyProvider.java
>  8b60c50 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/timeline/MetricsRequestHelper.java
>  ca20e54 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/timeline/cache/TimelineMetricCache.java
>  9e343e3 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/timeline/cache/TimelineMetricCacheEntryFactory.java
>  e8a2aef 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/metrics/timeline/AMSPropertyProviderTest.java
>  ce865cf 
> 
> Diff: https://reviews.apache.org/r/46751/diff/
> 
> 
> Testing
> -------
> 
> Added a unit test. Manually verified the patch works on a cluster.
> 
> 
> Thanks,
> 
> Sid Wagle
> 
>

Reply via email to