> On April 28, 2016, 2:50 a.m., Sumit Mohanty wrote:
> > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/alerts/alert_llap_app_status.py,
> >  line 22
> > <https://reviews.apache.org/r/46760/diff/1/?file=1364283#file1364283line22>
> >
> >     Lets remove all the commented lines.

Fixed.


> On April 28, 2016, 2:50 a.m., Sumit Mohanty wrote:
> > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/alerts/alert_llap_app_status.py,
> >  line 38
> > <https://reviews.apache.org/r/46760/diff/1/?file=1364283#file1364283line38>
> >
> >     Wasn't there a fix for Hive Metastore Alert as well?

Fixed. Had a separate bug on it. Adding to this now.


> On April 28, 2016, 2:50 a.m., Sumit Mohanty wrote:
> > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/alerts/alert_llap_app_status.py,
> >  line 88
> > <https://reviews.apache.org/r/46760/diff/1/?file=1364283#file1364283line88>
> >
> >     lets delete this.

Done.


> On April 28, 2016, 2:50 a.m., Sumit Mohanty wrote:
> > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/alerts/alert_llap_app_status.py,
> >  line 122
> > <https://reviews.apache.org/r/46760/diff/1/?file=1364283#file1364283line122>
> >
> >     There is no config property here - I assume. I was wondering if we can 
> > read from a property rather than making it a constant.

Added a config prop.


> On April 28, 2016, 2:50 a.m., Sumit Mohanty wrote:
> > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/alerts/alert_llap_app_status.py,
> >  line 220
> > <https://reviews.apache.org/r/46760/diff/1/?file=1364283#file1364283line220>
> >
> >     Lets remove this.

Done.


- Swapan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46760/#review130876
-----------------------------------------------------------


On April 28, 2016, 1:41 a.m., Swapan Shridhar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46760/
> -----------------------------------------------------------
> 
> (Updated April 28, 2016, 1:41 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and Sumit 
> Mohanty.
> 
> 
> Bugs: AMBARI-16149
>     https://issues.apache.org/jira/browse/AMBARI-16149
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> - Checks LLAP app status by running Hive Server2 " --service llapstatus 
> --name <llapAppName>" command.
> 
> 
> Diffs
> -----
> 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/alerts.json 
> 9f0466c 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/alerts/alert_llap_app_status.py
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/46760/diff/
> 
> 
> Testing
> -------
> 
> Python UT passes.
> 
> 
> File Attachments
> ----------------
> 
> App in COMPLETE state . Cluster Kerberized.
>   
> https://reviews.apache.org/media/uploaded/files/2016/04/28/7647a8e8-df5e-4d62-a6a5-0c13d7e47e96__Screen_Shot_2016-04-27_at_6.26.49_PM.png
> App in RUNNING_ALL state . Cluster un-Kerberized.
>   
> https://reviews.apache.org/media/uploaded/files/2016/04/28/deaef102-4b0a-42a0-8262-31d357509048__Screen_Shot_2016-04-27_at_5.59.32_PM.png
> App in LAUNCHING state . Cluster Kerberized.
>   
> https://reviews.apache.org/media/uploaded/files/2016/04/28/7a9c5482-f8e2-43e0-b9f9-08e5a62ed97b__Screen_Shot_2016-04-27_at_6.40.46_PM.png
> 
> 
> Thanks,
> 
> Swapan Shridhar
> 
>

Reply via email to