-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46765/#review130896
-----------------------------------------------------------


Ship it!




Ship It!

- Sebastian Toader


On April 28, 2016, 11:06 a.m., Daniel Gergely wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46765/
> -----------------------------------------------------------
> 
> (Updated April 28, 2016, 11:06 a.m.)
> 
> 
> Review request for Ambari, Laszlo Puskas, Oliver Szabo, Sandor Magyari, and 
> Sebastian Toader.
> 
> 
> Bugs: AMBARI-16150
>     https://issues.apache.org/jira/browse/AMBARI-16150
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> When hive metastore or webhcat is killed, the process is the following:
> 1. If process is running, then graceful kill
> 2. If process is still running wait 5 seconds
> 3. If process is still running, hard kill with kill -9
> 
> It is possible that process is running when check is done, but finishes 
> before issuing kill -9. As a result kill -9 fails with "no process" error.
> Adding the flag "ignore_failures" swallows this exception. This is not a 
> problem at all, since if there is no process, then nothing to be done, if 
> there is a different error, then it means some serious issues with the linux 
> kernel itself. (signal SIGKILL is handled by the kernel)
> 
> Checking other parts of the code, this ignore_failures flag was everywhere 
> except here, so I guess is is missing by accident.
> 
> 
> Diffs
> -----
> 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_service.py
>  8399f9c 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_service.py
>  7d0a862 
>   ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_metastore.py 
> 6e27ded 
>   ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_server.py ea361fb 
>   ambari-server/src/test/python/stacks/2.0.6/HIVE/test_webhcat_server.py 
> c401375 
>   ambari-server/src/test/python/stacks/2.1/HIVE/test_hive_metastore.py 
> f238ecc 
> 
> Diff: https://reviews.apache.org/r/46765/diff/
> 
> 
> Testing
> -------
> 
> Total run:998
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> Daniel Gergely
> 
>

Reply via email to