> On April 28, 2016, 5:11 p.m., Robert Nettleton wrote:
> > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/logsearch_common.py,
> >  line 42
> > <https://reviews.apache.org/r/46789/diff/1/?file=1364915#file1364915line42>
> >
> >     It looks like the "ignore_fialures" parameter name in this call is 
> > mis-spelled. 
> >     
> >     I think this should be "ignore_failures". 
> >     
> >     This seems like something the python unit tests should catch as well.

thanks, i just realized i uploaded wrong patch here, but i will fix that on 
this one


- Oliver


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46789/#review130941
-----------------------------------------------------------


On April 28, 2016, 4:54 p.m., Oliver Szabo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46789/
> -----------------------------------------------------------
> 
> (Updated April 28, 2016, 4:54 p.m.)
> 
> 
> Review request for Ambari, Miklos Gergely, Robert Nettleton, and Sumit 
> Mohanty.
> 
> 
> Bugs: AMBARI-16167
>     https://issues.apache.org/jira/browse/AMBARI-16167
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> logfeeder json log was in wrong place.
> 
> 
> Diffs
> -----
> 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logfeeder-env.xml
>  190ee53 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logfeeder-site.xml
>  56552f2 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-admin-json.xml
>  ae2c90d 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-solr-env.xml
>  b3ea446 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/metainfo.xml 
> 40c289e 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/logsearch_common.py
>  56f7792 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py
>  7ed5c42 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logsearch.py
>  50018cb 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/output.config.json.j2
>  8216587 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/properties/logsearch-admin.json.j2
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/properties/solr-log4j.properties.j2
>  8666a58 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/properties/user_pass.json.j2
>  abb0ddb 
>   ambari-web/app/data/HDP2/site_properties.js 8851a78 
> 
> Diff: https://reviews.apache.org/r/46789/diff/
> 
> 
> Testing
> -------
> 
> FT: on 4 node cluster. Log was under /var/log/ambari-logsearch-logfeeder/
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>

Reply via email to