> On April 28, 2016, 5:11 p.m., Robert Nettleton wrote:
> > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/logsearch_common.py,
> >  line 42
> > <https://reviews.apache.org/r/46789/diff/1/?file=1364915#file1364915line42>
> >
> >     It looks like the "ignore_fialures" parameter name in this call is 
> > mis-spelled. 
> >     
> >     I think this should be "ignore_failures". 
> >     
> >     This seems like something the python unit tests should catch as well.
> 
> Oliver Szabo wrote:
>     thanks, i just realized i uploaded wrong patch here, but i will fix that 
> on this one

also i want to metnion python tests did not catch this, testing stop processes 
is missing, so I will need to do that later


- Oliver


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46789/#review130941
-----------------------------------------------------------


On April 28, 2016, 5:18 p.m., Oliver Szabo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46789/
> -----------------------------------------------------------
> 
> (Updated April 28, 2016, 5:18 p.m.)
> 
> 
> Review request for Ambari, Miklos Gergely, Robert Nettleton, and Sumit 
> Mohanty.
> 
> 
> Bugs: AMBARI-16167
>     https://issues.apache.org/jira/browse/AMBARI-16167
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> logfeeder json log was in wrong place.
> 
> 
> Diffs
> -----
> 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/logsearch_common.py
>  42f69d0 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/properties/logfeeder-log4j.xml.j2
>  77318ee 
> 
> Diff: https://reviews.apache.org/r/46789/diff/
> 
> 
> Testing
> -------
> 
> FT: on 4 node cluster. Log was under /var/log/ambari-logsearch-logfeeder/
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>

Reply via email to