> On April 28, 2016, 2:50 p.m., Jonathan Hurley wrote:
> > I've never installed LLAP before - Is this data you're getting exposed via 
> > JMX as a metric? It it was, it would save you a lot of effort in getting 
> > things like liveInstances.

I dont think it's getting exposed via JMX. i'll still check with HIVE team.


> On April 28, 2016, 2:50 p.m., Jonathan Hurley wrote:
> > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/alerts/alert_llap_app_status.py,
> >  lines 156-158
> > <https://reviews.apache.org/r/46760/diff/2/?file=1364429#file1364429line156>
> >
> >     Why not use Execute here? Is it because you need the exit code? I don't 
> > see it being used.

Using this call because I need to use the o/p (a JSON).


> On April 28, 2016, 2:50 p.m., Jonathan Hurley wrote:
> > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/alerts/alert_llap_app_status.py,
> >  lines 36-39
> > <https://reviews.apache.org/r/46760/diff/2/?file=1364429#file1364429line36>
> >
> >     As these are user-facing strings, let's have them reviewed for grammar 
> > and clarity. They seem very sterile and don't flow very well.

Any inputs on this. I want state and/or instances to be shown for better clarity


- Swapan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46760/#review130918
-----------------------------------------------------------


On April 28, 2016, 9:52 a.m., Swapan Shridhar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46760/
> -----------------------------------------------------------
> 
> (Updated April 28, 2016, 9:52 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and Sumit 
> Mohanty.
> 
> 
> Bugs: AMBARI-16149
>     https://issues.apache.org/jira/browse/AMBARI-16149
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> - Checks LLAP app status by running Hive Server2 " --service llapstatus 
> --name <llapAppName>" command.
> 
> 
> Diffs
> -----
> 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/alerts.json 
> 9f0466c 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/alerts/alert_hive_metastore.py
>  a556410 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/alerts/alert_llap_app_status.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
>  3d6c096 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-interactive-env.xml
>  aad9c47 
> 
> Diff: https://reviews.apache.org/r/46760/diff/
> 
> 
> Testing
> -------
> 
> Python UT passes.
> 
> 
> File Attachments
> ----------------
> 
> App in COMPLETE state . Cluster Kerberized.
>   
> https://reviews.apache.org/media/uploaded/files/2016/04/28/7647a8e8-df5e-4d62-a6a5-0c13d7e47e96__Screen_Shot_2016-04-27_at_6.26.49_PM.png
> App in RUNNING_ALL state . Cluster un-Kerberized.
>   
> https://reviews.apache.org/media/uploaded/files/2016/04/28/deaef102-4b0a-42a0-8262-31d357509048__Screen_Shot_2016-04-27_at_5.59.32_PM.png
> App in LAUNCHING state . Cluster Kerberized.
>   
> https://reviews.apache.org/media/uploaded/files/2016/04/28/7a9c5482-f8e2-43e0-b9f9-08e5a62ed97b__Screen_Shot_2016-04-27_at_6.40.46_PM.png
> Hive Metastore alert
>   
> https://reviews.apache.org/media/uploaded/files/2016/04/28/0c495516-0e0b-4e46-a8c3-4ea03f32ab1d__Screen_Shot_2016-04-28_at_2.27.03_AM.png
> 
> 
> Thanks,
> 
> Swapan Shridhar
> 
>

Reply via email to