-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46727/#review131041
-----------------------------------------------------------




ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/params.py
 (line 188)
<https://reviews.apache.org/r/46727/#comment194991>

    This seems a little odd that whether the stack is 2.5 or not is based on if 
ROLLING_UPGRADE is supported?



ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/service_check.py
 (line 45)
<https://reviews.apache.org/r/46727/#comment194990>

    Will Spark hist server and livy server always allow http calls? Do we need 
support for https?
    
    I also think that we can reduce the retries to 5 times. Any reason 
service_check should keep on trying 10 times?



ambari-server/src/main/resources/common-services/SPARK/1.6.x.2.5/configuration/livy-defaults.xml
 (line 44)
<https://reviews.apache.org/r/46727/#comment194989>

    One hour seems too long. Will it have any impact of start/service check?



ambari-server/src/main/resources/stacks/HDP/2.4/services/SPARK/metainfo.xml 
(line 27)
<https://reviews.apache.org/r/46727/#comment195031>

    What is the motivation to move these to common-services?



ambari-server/src/main/resources/stacks/HDP/2.5/role_command_order.json (line 
10)
<https://reviews.apache.org/r/46727/#comment194988>

    Why does LIVY server need all the four to be started?
    
    Does SPARK service check also need to wait for LIVY server start?


- Sumit Mohanty


On April 29, 2016, 7:45 a.m., Jeff Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46727/
> -----------------------------------------------------------
> 
> (Updated April 29, 2016, 7:45 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Sumit 
> Mohanty.
> 
> 
> Bugs: AMBARI-15612
>     https://issues.apache.org/jira/browse/AMBARI-15612
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Add Livy to HDP 2.5 as slave component of Spark.
> 
> Move the spark stack definiation to commoon-services and then
> 
> 
> Diffs
> -----
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/constants.py
>  abd2212 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/stack_features.py
>  daa97de 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/livy_server.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/livy_service.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/params.py
>  c5f3eb6 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/service_check.py
>  694f046 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/setup_livy.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/status_params.py
>  86e7f7d 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.6.x.2.4/configuration/spark-defaults.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.6.x.2.4/configuration/spark-thrift-fairscheduler.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.6.x.2.4/configuration/spark-thrift-sparkconf.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.6.x.2.4/metainfo.xml 
> PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.6.x.2.5/configuration/livy-defaults.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.6.x.2.5/configuration/livy-env.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.6.x.2.5/configuration/livy-log4j-properties.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.6.x.2.5/kerberos.json
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.6.x.2.5/metainfo.xml 
> PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/HDP/2.4/services/SPARK/configuration/spark-defaults.xml
>  1a6552f 
>   
> ambari-server/src/main/resources/stacks/HDP/2.4/services/SPARK/configuration/spark-thrift-fairscheduler.xml
>  2dda4bb 
>   
> ambari-server/src/main/resources/stacks/HDP/2.4/services/SPARK/configuration/spark-thrift-sparkconf.xml
>  4f2563b 
>   ambari-server/src/main/resources/stacks/HDP/2.4/services/SPARK/metainfo.xml 
> a5a19f6 
>   ambari-server/src/main/resources/stacks/HDP/2.5/role_command_order.json 
> f7e15aa 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/SPARK/metainfo.xml 
> 107ca93 
> 
> Diff: https://reviews.apache.org/r/46727/diff/
> 
> 
> Testing
> -------
> 
> Manully verify it. Livy is installed correctly in non-secure and secure 
> cluster.
> 
> 
> Thanks,
> 
> Jeff Zhang
> 
>

Reply via email to