-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46820/#review131146
-----------------------------------------------------------


Fix it, then Ship it!





ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py (line 
741)
<https://reviews.apache.org/r/46820/#comment195078>

    this is inefficient, just check > 0 and < 100. the range function creates a 
list every time


- Alejandro Fernandez


On April 29, 2016, 11:08 a.m., Swapan Shridhar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46820/
> -----------------------------------------------------------
> 
> (Updated April 29, 2016, 11:08 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-16178
>     https://issues.apache.org/jira/browse/AMBARI-16178
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> - As we are recommending the minimum llap queue size require dto have a 
> meaningful run of LLAP, the minimum required llap queue size is not 
> persistent across HSI on and off.
> - Fixes other calculations work.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
> 03af7c0 
>   ambari-server/src/test/python/stacks/2.5/common/test_stack_advisor.py 
> 8f4a5c2 
> 
> Diff: https://reviews.apache.org/r/46820/diff/
> 
> 
> Testing
> -------
> 
> Python UT passes.
> 
> 
> Thanks,
> 
> Swapan Shridhar
> 
>

Reply via email to