> On April 29, 2016, 9:12 p.m., jun aoki wrote:
> > ambari-web/app/utils/configs/move_namenode_config_initializer.js, line 113
> > <https://reviews.apache.org/r/46852/diff/1/?file=1367645#file1367645line113>
> >
> >     Did you test if this works when HAWQ is not installed?

Did not test it yet without HAWQ, will do. 
However, it will work.


> On April 29, 2016, 9:12 p.m., jun aoki wrote:
> > ambari-web/app/controllers/main/service/reassign/step4_controller.js, line 
> > 571
> > <https://reviews.apache.org/r/46852/diff/1/?file=1367644#file1367644line571>
> >
> >     you can use serviceToConfigSiteMap structure to add HAWQ.

Yes i could have, but to keep in sync with the current codebase (HBASE and 
ACCUMULO service configuration are updated in case of NAMENODE move as well), 
so added it here. So will keep it as is.


- bhuvnesh


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46852/#review131189
-----------------------------------------------------------


On April 29, 2016, 8:50 p.m., bhuvnesh chaudhary wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46852/
> -----------------------------------------------------------
> 
> (Updated April 29, 2016, 8:50 p.m.)
> 
> 
> Review request for Ambari, Alexander Denissov, jun aoki, Matt, and Oleksandr 
> Diachenko.
> 
> 
> Bugs: AMBARI-16191
>     https://issues.apache.org/jira/browse/AMBARI-16191
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> HAWQ Configuration should be updated whenever Namenode is being moved using 
> the move namenode wizard.
> Parameters which should be updated
> Case 1: HDFS HA
> hdfs-client parameters under HAWQ service
> dfs.namenode.rpc-address.<nameservice>.<nnid>
> dfs.namenode.http-address.<nameservice>.<nnid>
> Case 2: Non HA HDFS
> hawq-site parmeters under HAWQ service
> hawq_dfs_url
> 
> 
> Diffs
> -----
> 
>   ambari-web/app/controllers/main/service/reassign/step4_controller.js 
> a20aa82 
>   ambari-web/app/utils/configs/move_namenode_config_initializer.js 160848c 
>   ambari-web/test/controllers/main/service/reassign/step4_controller_test.js 
> 460726b 
> 
> Diff: https://reviews.apache.org/r/46852/diff/
> 
> 
> Testing
> -------
> 
> yes.
>   27472 tests complete (29 seconds)
>   154 tests pending
> [INFO] 
> ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] 
> ------------------------------------------------------------------------
> [INFO] Total time: 46.556 s
> [INFO] Finished at: 2016-04-29T13:53:51-07:00
> [INFO] Final Memory: 14M/338M
> 
> 
> Thanks,
> 
> bhuvnesh chaudhary
> 
>

Reply via email to