-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46898/
-----------------------------------------------------------

Review request for Ambari, Nate Cole and Sid Wagle.


Bugs: AMBARI-16207
    https://issues.apache.org/jira/browse/AMBARI-16207


Repository: ambari


Description
-------

There is currently no way to pass JPA or EclipseLink specific 
connection/DataSource properties in from {{ambari.properties}}. Although there 
exists {{Configuration.getDatabaseCustomProperties}}, these are actually 
_driver specific_ properties and not properties for EclipseLink.

For example, if I wanted to pass in to the JDBC Driver {{foo=bar}}, then I 
could set
{{server.jdbc.properties.foo=bar}} and this will get translated into 
{{eclipselink.jdbc.property.foo=bar}}.

However, if I wanted to set any of the EclipseLink or JPA specific DataSource 
properties (see 
http://www.eclipse.org/eclipselink/api/2.6/org/eclipse/persistence/config/PersistenceUnitProperties.html)
 I would not be able to.

Proposal is to add something similar to the custom driver properties:
```
server.persistence.properties.eclipselink.jdbc.batch-writing.size=25
```

Which could get translated into
```
properties.put("eclipselink.jdbc.batch-writing.size", 25)
```


Diffs
-----

  
ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
 0afae97 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java
 3506031 
  
ambari-server/src/test/java/org/apache/ambari/server/configuration/ConfigurationTest.java
 99ec786 

Diff: https://reviews.apache.org/r/46898/diff/


Testing
-------

mvn clean test


Thanks,

Jonathan Hurley

Reply via email to