> On May 2, 2016, 2:44 p.m., Ajit Kumar wrote:
> > ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql, line 856
> > <https://reviews.apache.org/r/46545/diff/2/?file=1369073#file1369073line856>
> >
> >     missed renaming this.

Fixed.


> On May 2, 2016, 2:44 p.m., Ajit Kumar wrote:
> > ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql, line 837
> > <https://reviews.apache.org/r/46545/diff/2/?file=1369067#file1369067line837>
> >
> >     Othere tables have start_time as the column name. It will be good to 
> > have the same name.

Originally it was start_timestamp and stop_timestamp. One of the reviews was 
end_timestamp made more sense; this meant that start_timestamp would change to 
begin_timestamp. (Start<->Stop, Begin<->End).


- Nahappan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46545/#review131379
-----------------------------------------------------------


On May 2, 2016, 2:24 p.m., Nahappan Somasundaram wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46545/
> -----------------------------------------------------------
> 
> (Updated May 2, 2016, 2:24 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Ajit Kumar, Jonathan Hurley, 
> Jayush Luniya, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-16029
>     https://issues.apache.org/jira/browse/AMBARI-16029
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> AMBARI-16029: Ambari version history - Create DB table, constraints and 
> sequence id.
> 
> ** Issue **
> In order to support tracking of ambari version, a DB table is required.
> 
> ** Fix **
> Create ambari_operation_history table to store from version, to version, 
> install type, start and stop timestamps.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql 
> 319afa579e6f5090588fb90fe619ee7b6bae6d78 
>   ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 
> 9a20b8c05801f61a91a092afd4424173a94d7f17 
>   ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 
> e1da7190d6fb929277c834b29cb537107d857bc3 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 
> ab1eec42fcba467e0bae19674a7877c79eb77b8e 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql 
> bd869f454ae7ec1c84a9cbd418875f10c023a0c2 
>   ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 
> fdba489f2d0759e9c1282dfad38036f9bce3673d 
>   ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 
> a1da8e5c8343ae554b4e95717cda085c7f79bc46 
> 
> Diff: https://reviews.apache.org/r/46545/diff/
> 
> 
> Testing
> -------
> 
> ** 1. mvn clean install **
> 
> [INFO] 
> ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Main ....................................... SUCCESS [5.113s]
> [INFO] Apache Ambari Project POM ......................... SUCCESS [0.038s]
> [INFO] Ambari Web ........................................ SUCCESS [26.897s]
> [INFO] Ambari Views ...................................... SUCCESS [1.400s]
> [INFO] Ambari Admin View ................................. SUCCESS [9.242s]
> [INFO] ambari-metrics .................................... SUCCESS [0.346s]
> [INFO] Ambari Metrics Common ............................. SUCCESS [0.528s]
> [INFO] Ambari Metrics Hadoop Sink ........................ SUCCESS [1.237s]
> [INFO] Ambari Metrics Flume Sink ......................... SUCCESS [0.566s]
> [INFO] Ambari Metrics Kafka Sink ......................... SUCCESS [0.600s]
> [INFO] Ambari Metrics Storm Sink ......................... SUCCESS [1.531s]
> [INFO] Ambari Metrics Collector .......................... SUCCESS [7.183s]
> [INFO] Ambari Metrics Monitor ............................ SUCCESS [1.853s]
> [INFO] Ambari Metrics Grafana ............................ SUCCESS [1.031s]
> [INFO] Ambari Metrics Assembly ........................... SUCCESS [1:18.252s]
> [INFO] Ambari Server ..................................... SUCCESS [2:58.522s]
> [INFO] Ambari Functional Tests ........................... SUCCESS [2.194s]
> [INFO] Ambari Agent ...................................... SUCCESS [25.339s]
> [INFO] Ambari Client ..................................... SUCCESS [0.047s]
> [INFO] Ambari Python Client .............................. SUCCESS [0.947s]
> [INFO] Ambari Groovy Client .............................. SUCCESS [2.196s]
> [INFO] Ambari Shell ...................................... SUCCESS [0.038s]
> [INFO] Ambari Python Shell ............................... SUCCESS [0.693s]
> [INFO] Ambari Groovy Shell ............................... SUCCESS [0.907s]
> [INFO] ambari-logsearch .................................. SUCCESS [0.253s]
> [INFO] Ambari Logsearch Portal ........................... SUCCESS [7.069s]
> [INFO] Ambari Logsearch Log Feeder ....................... SUCCESS [1.570s]
> [INFO] Ambari Logsearch Appender ......................... SUCCESS [0.190s]
> [INFO] Ambari Logsearch Assembly ......................... SUCCESS [0.079s]
> [INFO] 
> ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] 
> ------------------------------------------------------------------------
> [INFO] Total time: 5:56.545s
> [INFO] Finished at: Thu Apr 21 16:14:34 PDT 2016
> [INFO] Final Memory: 274M/1094M
> [INFO] 
> ------------------------------------------------------------------------
> 
> 
> ** 2. Manual testing **
> Tested with Ambari-DDL-Postgres-EMBEDDED-CREATE.sql. Copied the SQL script to 
> a VM and ran ambari-server reset. Verified the schema:
> 
> ambari=> \d+ ambari_version_history
>                      Table "ambari.ambari_version_history"
>      Column      |          Type          | Modifiers | Storage  | Description
> -----------------+------------------------+-----------+----------+-------------
>  id              | bigint                 | not null  | plain    |
>  from_version    | character varying(255) | not null  | extended |
>  to_version      | character varying(255) | not null  | extended |
>  start_timestamp | bigint                 | not null  | plain    |
>  stop_timestamp  | bigint                 |           | plain    |
>  install_type    | character varying(255) | not null  | extended |
> Indexes:
>     "pk_ambari_version_history" PRIMARY KEY, btree (id)
> Has OIDs: no
> 
> 
> Thanks,
> 
> Nahappan Somasundaram
> 
>

Reply via email to