> On April 29, 2016, 5:21 p.m., bhuvnesh chaudhary wrote:
> > ambari-web/app/controllers/main/service/reassign/step4_controller.js, line 
> > 85
> > <https://reviews.apache.org/r/46860/diff/1/?file=1367779#file1367779line85>
> >
> >     Unless HAWQ is using YARN as the scheduler, HAWQ may still be 
> > functional and we may need not restart HAWQ with the move of RM. 
> >     So do you think should we restart it only when HAWQ is using 
> > hawq_global_rm_type as yarn ?
> 
> jun aoki wrote:
>     I thought it'd be a good idea but data.Cluters won't return enoguh 
> information to decide if HAWQ is on YARN. 
>     ```
>     data.Clusters.desired_configs["hawq-site"]
>     Object {tag: "TOPOLOGY_RESOLVED", user: "admin", version: 2}
>     ```
>     Let me know if you have a better idea to find it out.
> 
> bhuvnesh chaudhary wrote:
>     You can get the configuration as soon you reach onLoadConfigs, and then 
> you can use it which is before the start service ?

That sounds better to me. Modify the array after receiving the config.
If HAWQ is using YARN, append value 'HAWQ' to RESOURCEMANAGER's array value.


- Matt


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46860/#review131231
-----------------------------------------------------------


On May 2, 2016, 2:47 p.m., jun aoki wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46860/
> -----------------------------------------------------------
> 
> (Updated May 2, 2016, 2:47 p.m.)
> 
> 
> Review request for Ambari.
> 
> 
> Bugs: AMBARI-16174
>     https://issues.apache.org/jira/browse/AMBARI-16174
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> when RM HA is not enabled, following properties should be updated in 
> hawq-site.xml should be updated.
> hawq_rm_yarn_address
> hawq_rm_yarn_scheduler_address
> When RM HA Is enabled and then a RM is moved, following properties in 
> yarn-client.xml should be updated
> yarn.resourcemanager.ha
> yarn.resourcemanager.scheduler.ha
> 
> 
> Diffs
> -----
> 
>   ambari-web/app/controllers/main/service/reassign/step4_controller.js 
> 736f467 
>   ambari-web/app/utils/configs/move_rm_config_initializer.js f8800de 
>   ambari-web/test/controllers/main/service/reassign/step4_controller_test.js 
> 329249c 
> 
> Diff: https://reviews.apache.org/r/46860/diff/
> 
> 
> Testing
> -------
> 
> Unit test passed
> Calling set on destroyed view
> 
>   27428 tests complete (35 seconds)
>   154 tests pending
> 
> 
> Manually tested
> 
> 
> Thanks,
> 
> jun aoki
> 
>

Reply via email to