> On May 2, 2016, 10:31 p.m., bhuvnesh chaudhary wrote:
> > ambari-web/app/controllers/main/service/reassign/step4_controller.js, line 
> > 581
> > <https://reviews.apache.org/r/46860/diff/2/?file=1369090#file1369090line581>
> >
> >     somehow placing the logic here does not fit well to the method, you can 
> > move this logic to setAdditionalConfigs which imo more appropriate place 
> > and hopefully it will work there too as its used after setting additional 
> > configurations ?

setAdditionalConfigs() (at least intention ) is to simply take 
additionalConfigsMap parameter and transform it in "configs", so it shouldn't 
have some condition logic to modify the parameter.
Instead, we should modify the parameter, additionalConfigsMap beforehand, which 
onLoadConfigs() as you suggested.


- jun


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46860/#review131403
-----------------------------------------------------------


On May 3, 2016, 12:59 a.m., jun aoki wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46860/
> -----------------------------------------------------------
> 
> (Updated May 3, 2016, 12:59 a.m.)
> 
> 
> Review request for Ambari.
> 
> 
> Bugs: AMBARI-16174
>     https://issues.apache.org/jira/browse/AMBARI-16174
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> when RM HA is not enabled, following properties should be updated in 
> hawq-site.xml should be updated.
> hawq_rm_yarn_address
> hawq_rm_yarn_scheduler_address
> When RM HA Is enabled and then a RM is moved, following properties in 
> yarn-client.xml should be updated
> yarn.resourcemanager.ha
> yarn.resourcemanager.scheduler.ha
> 
> 
> Diffs
> -----
> 
>   ambari-web/app/controllers/main/service/reassign/step4_controller.js 
> 736f467 
>   ambari-web/app/utils/configs/move_rm_config_initializer.js f8800de 
>   ambari-web/test/controllers/main/service/reassign/step4_controller_test.js 
> 329249c 
> 
> Diff: https://reviews.apache.org/r/46860/diff/
> 
> 
> Testing
> -------
> 
> Unit test passed
> Calling set on destroyed view
> 
>   27428 tests complete (35 seconds)
>   154 tests pending
> 
> 
> Manually tested
> 
> 
> Thanks,
> 
> jun aoki
> 
>

Reply via email to