----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46925/#review131499 -----------------------------------------------------------
ambari-server/src/test/python/stacks/2.5/HIVE/test_hive_server_int.py (line 180) <https://reviews.apache.org/r/46925/#comment195504> Looks like the parenthesis got auto-formated. ambari-server/src/test/python/stacks/2.5/HIVE/test_hive_server_int.py (line 268) <https://reviews.apache.org/r/46925/#comment195506> Formatting of parenthesis not consistent with existing code. ambari-server/src/test/python/stacks/2.5/HIVE/test_hive_server_int.py (line 270) <https://reviews.apache.org/r/46925/#comment195505> Is the newline intentional? - Nahappan Somasundaram On May 2, 2016, 9:27 p.m., Sumit Mohanty wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46925/ > ----------------------------------------------------------- > > (Updated May 2, 2016, 9:27 p.m.) > > > Review request for Ambari, Nahappan Somasundaram and Swapan Shridhar. > > > Bugs: AMBARI-16209 > https://issues.apache.org/jira/browse/AMBARI-16209 > > > Repository: ambari > > > Description > ------- > > Write out new log property files under /etc/hive2/conf > llap-daemon-log4j2.properties (from llap-daemon-log4j2.properties.template) > llap-cli-log4j2.properties (from llap-cli-log4j2.properties.template) > > > Diffs > ----- > > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_interactive.py > 24047ff > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py > 2e1a2af > > ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/llap-daemon-log4j.xml > 1c60285 > ambari-server/src/test/python/stacks/2.5/HIVE/test_hive_server_int.py > 5712995 > ambari-server/src/test/python/stacks/2.5/configs/hsi_default.json e7bb056 > > Diff: https://reviews.apache.org/r/46925/diff/ > > > Testing > ------- > > Ran unit tests. > > > Thanks, > > Sumit Mohanty > >