----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46853/ -----------------------------------------------------------
(Updated May 3, 2016, 6:12 p.m.) Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Matt. Bugs: AMBARI-16175 https://issues.apache.org/jira/browse/AMBARI-16175 Repository: ambari Description ------- Python code at at common-services level used generic imports form resource_management (from resource_management import *) Ideally, for easier code tracking and performance, these import should be more specific, such as: from resource_management.libraries.script.script import Script from resource_management.core.resources.system import Directory This subtask cleans up import * from resource_management and replace it for specific imports for: Accumulo, Ambari-metrics, Atlas, Falcon, Flume and Ganglia services Diffs ----- ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/accumulo_configuration.py 09a3d90 ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/accumulo_service.py 33d3273 ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/service_check.py a7067cb ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/ams.py 3c3d804 ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/ams_service.py eb1b6d7 ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/hbase.py 7fb9715 ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/hbase_master.py b769a0d ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/hbase_regionserver.py cf0efef ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/hbase_service.py 4d0d7f3 ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_collector.py a5abe1c ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params.py 32b8fdb ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params_linux.py 21b491d ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/status_params.py 3c4bffc ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/atlas_client.py 2bdb4c0 ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/metadata.py 43c1ea6 ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/metadata_server.py 4b08cbc ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/params.py defd6f0 ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/service_check.py 194a3fb ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/status_params.py 4c54214 ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon_client.py 64ace1a ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon_server.py a201619 ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon_server_upgrade.py 6277086 ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/params_windows.py b213028 ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/service_check.py 473b7c3 ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/scripts/flume.py 9df2ba6 ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/scripts/flume_check.py 25d9a08 ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/scripts/flume_handler.py 1333605 ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/scripts/params_windows.py 66e9852 ambari-server/src/main/resources/common-services/GANGLIA/3.5.0/package/scripts/functions.py 02c44f0 ambari-server/src/main/resources/common-services/GANGLIA/3.5.0/package/scripts/ganglia.py 9a69b72 ambari-server/src/main/resources/common-services/GANGLIA/3.5.0/package/scripts/ganglia_monitor.py feb0af3 ambari-server/src/main/resources/common-services/GANGLIA/3.5.0/package/scripts/ganglia_monitor_service.py 58d512c ambari-server/src/main/resources/common-services/GANGLIA/3.5.0/package/scripts/ganglia_server.py 8d75d7f ambari-server/src/main/resources/common-services/GANGLIA/3.5.0/package/scripts/ganglia_server_service.py 70fdbf6 ambari-server/src/main/resources/common-services/GANGLIA/3.5.0/package/scripts/params.py 30f8ee4 ambari-server/src/main/resources/common-services/GANGLIA/3.5.0/package/scripts/status_params.py 0c69ca9 Diff: https://reviews.apache.org/r/46853/diff/ Testing (updated) ------- Sucessfull tests by Hadoop QA Manual fresh installation and service checks Thanks, Juanjo Marron