-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44210/
-----------------------------------------------------------
(Updated May 3, 2016, 7:04 p.m.)
Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, Jayush
Luniya, Oleksandr Diachenko, Sumit Mohanty, Srimanth Gunturi, and Yusaku Sako.
Changes
-------
This fixes the issue Lav brought up about configuration validation not calling
the service advisors.
Bugs: AMBARI-15226
https://issues.apache.org/jira/browse/AMBARI-15226
Repository: ambari
Description
-------
Currently the stack advisor is defined under each stack version such as
HDP/2.3. The problem with this is that it restricts the services that can be
added to the stack. If a custom service is to be added, they would need to
modify the stack advisor. If the configuration recommendation and validation
can be done at the service level then the custom service could just include
their own recommendations and validations separately.
Diffs (updated)
-----
ambari-server/src/main/assemblies/server.xml e1a4919
ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java
df65010
ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/commands/StackAdvisorCommand.java
00c8696
ambari-server/src/main/java/org/apache/ambari/server/controller/StackServiceResponse.java
ca1968e
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackServiceResourceProvider.java
6c6fa91
ambari-server/src/main/java/org/apache/ambari/server/stack/CommonServiceDirectory.java
636de37
ambari-server/src/main/java/org/apache/ambari/server/stack/ServiceDirectory.java
356adb1
ambari-server/src/main/java/org/apache/ambari/server/stack/ServiceModule.java
b7e09a9
ambari-server/src/main/java/org/apache/ambari/server/stack/StackServiceDirectory.java
d27e52a
ambari-server/src/main/java/org/apache/ambari/server/state/ServiceInfo.java
5a2bf84
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/service_advisor.py
PRE-CREATION
ambari-server/src/main/resources/common-services/PXF/3.0.0/service_advisor.py
PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py
1680f21
ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py
f475798
ambari-server/src/main/resources/stacks/service_advisor.py PRE-CREATION
ambari-server/src/main/resources/stacks/stack_advisor.py 9979e7e
ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py 2080c52
Diff: https://reviews.apache.org/r/44210/diff/
Testing
-------
Ran all the non java unit tests.
Total run:945
Total errors:0
Total failures:0
Manually configured HAWQ and PXF as part of the HDP 2.3 stack and made sure
their service advisors were called.
Thanks,
Tim Thorpe
