-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46727/
-----------------------------------------------------------

(Updated May 4, 2016, 6:20 a.m.)


Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Sumit 
Mohanty.


Changes
-------

address comments.  @jluniya I try to verify the changes in stack_features.py, 
but fails. This is because check_stack_feature(StackFeature.SPARK_LIVY, 
stack_version_formatted) always return False. And I found in method 
check_stack_feature, it always load another stack_features_config which dont' 
have the new component spark_livy.

  stack_features_config = default("/configurations/cluster-env/stack_features", 
None)
  data = _DEFAULT_STACK_FEATURES
  if stack_feature == "spark_livy":
    print("**************stack_features_config")
    print(stack_features_config)
  if not stack_version:
    return False

  if stack_features_config:
    data = json.loads(stack_features_config)        // this if block is always 
executed, and there's no new component spark_livy I defined in constants.py, is 
there any place I miss to add ?
    if stack_feature == "spark_livy":
      print("*************load it ")


Bugs: AMBARI-15612
    https://issues.apache.org/jira/browse/AMBARI-15612


Repository: ambari


Description
-------

Add Livy to HDP 2.5 as slave component of Spark.

Move the spark stack definiation to commoon-services and then


Diffs (updated)
-----

  
ambari-common/src/main/python/resource_management/libraries/functions/constants.py
 abd2212 
  
ambari-common/src/main/python/resource_management/libraries/functions/stack_features.py
 daa97de 
  
ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/livy_server.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/livy_service.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/params.py
 c5f3eb6 
  
ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/service_check.py
 694f046 
  
ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/setup_livy.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/status_params.py
 86e7f7d 
  
ambari-server/src/main/resources/common-services/SPARK/1.6.x/configuration/spark-defaults.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/SPARK/1.6.x/configuration/spark-thrift-fairscheduler.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/SPARK/1.6.x/configuration/spark-thrift-sparkconf.xml
 PRE-CREATION 
  ambari-server/src/main/resources/common-services/SPARK/1.6.x/metainfo.xml 
PRE-CREATION 
  
ambari-server/src/main/resources/common-services/SPARK/1.6.x2/configuration/livy-defaults.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/SPARK/1.6.x2/configuration/livy-env.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/SPARK/1.6.x2/configuration/livy-log4j-properties.xml
 PRE-CREATION 
  ambari-server/src/main/resources/common-services/SPARK/1.6.x2/kerberos.json 
PRE-CREATION 
  ambari-server/src/main/resources/common-services/SPARK/1.6.x2/metainfo.xml 
PRE-CREATION 
  
ambari-server/src/main/resources/stacks/HDP/2.4/services/SPARK/configuration/spark-defaults.xml
 1a6552f 
  
ambari-server/src/main/resources/stacks/HDP/2.4/services/SPARK/configuration/spark-thrift-fairscheduler.xml
 2dda4bb 
  
ambari-server/src/main/resources/stacks/HDP/2.4/services/SPARK/configuration/spark-thrift-sparkconf.xml
 4f2563b 
  ambari-server/src/main/resources/stacks/HDP/2.4/services/SPARK/metainfo.xml 
a5a19f6 
  ambari-server/src/main/resources/stacks/HDP/2.5/role_command_order.json 
f7e15aa 
  ambari-server/src/main/resources/stacks/HDP/2.5/services/SPARK/metainfo.xml 
107ca93 

Diff: https://reviews.apache.org/r/46727/diff/


Testing
-------

Manully verify it. Livy is installed correctly in non-secure and secure cluster.


Thanks,

Jeff Zhang

Reply via email to