----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46977/#review131677 -----------------------------------------------------------
Ship it! Ship It! - Jonathan Hurley On May 4, 2016, 10:11 a.m., Nate Cole wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46977/ > ----------------------------------------------------------- > > (Updated May 4, 2016, 10:11 a.m.) > > > Review request for Ambari, Jonathan Hurley and Jayush Luniya. > > > Bugs: AMBARI-16251 > https://issues.apache.org/jira/browse/AMBARI-16251 > > > Repository: ambari > > > Description > ------- > > The cause of this bug is not obvious. In the upgrade/downgrade cycle for > HDP-2.2 upgrade to HDP-2.4 downgrade to HDP-2.2, the Metastore upgrade_schema > method will invoke configure(). This in turn creates (correctly) > {{/usr/hdp/current/hive-metastore/conf/conf.server}} to place configs. The > bug is that upgrade_schema happens BEFORE hdp-select is called, so the > directory is created within HDP-2.2. Then on downgrade, that directory is > left intact. > > The alert checks for existence of {{current/.../conf/conf.server}} as an > indication of where to look for configs. Since that directory is incorrect > for HDP-2.2, the wrong configs are loaded when running the alert script. > This is an issue when security is enabled since the wrong configs are now > checked. > > The fix is to invoke upgrade_schema AFTER hdp-select instead of before. That > way, the {{current/.../conf/conf.server}} directory is created in the correct > directory in the version that supports it. > > > Diffs > ----- > > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_metastore.py > 0b9d134 > ambari-server/src/test/python/stacks/2.1/HIVE/test_hive_metastore.py > 80284a3 > > Diff: https://reviews.apache.org/r/46977/diff/ > > > Testing > ------- > > Manual. Automated: > > ---------------------------------------------------------------------- > Total run:1013 > Total errors:0 > Total failures:0 > OK > > > Thanks, > > Nate Cole > >
