> On May 4, 2016, 11:37 p.m., Sriharsha Chintalapani wrote:
> > Lets wait till AMBARI-16210 gets merged in. Since we are shipping 1.0 with 
> > Ambari 2.4 that needs to be part of this patch as well.

@Sriharsha, 
Sumit already committed that patch and the latest patch on the review 
encompasses those changes.


- Jayush


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46976/#review131759
-----------------------------------------------------------


On May 4, 2016, 11:21 p.m., Jayush Luniya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46976/
> -----------------------------------------------------------
> 
> (Updated May 4, 2016, 11:21 p.m.)
> 
> 
> Review request for Ambari, Sumit Mohanty and Sriharsha Chintalapani.
> 
> 
> Bugs: AMBARI-16250
>     https://issues.apache.org/jira/browse/AMBARI-16250
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Create common-services/STORM/0.9.1 common-services/SOTRM/0.9.3 and 
> common-services/SOTRM/0.10.0 service versions and update HDP stack 
> inheritance to extend these service definitions
> 
> - Moved common-services/STORM/0.9.1.2.1 -> common-services/STORM/0.9.1
> - Moved stacks/HDP/2.2/services/STORM -> common-services/STORM/0.9.3
> - Moved stacks/HDP/2.3/services/STORM -> common-services/STORM/0.10.0
> - Moved stacks/HDP/2.5/services/STORM -> common-services/STORM/1.0.1
> - Updating service versioning and inheritance hierarchy
> - Only kept hdp-specific config overrides in stacks/HDP and updated 
> corresponding config properties in common-services to default Apache values 
> (example: storm-site/nimbus.childopts)
> 
> 
> Diffs
> -----
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/ServiceModule.java 
> b7e09a94f1e6984af9276c26f302cd0995e20639 
>   ambari-server/src/main/java/org/apache/ambari/server/stack/StackModule.java 
> 5c8556f7fd121023d68e01f56f14c6ea27a6dc60 
>   
> ambari-server/src/main/resources/common-services/STORM/0.10.0/configuration/ranger-storm-audit.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/STORM/0.10.0/configuration/ranger-storm-plugin-properties.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/STORM/0.10.0/configuration/ranger-storm-policymgr-ssl.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/STORM/0.10.0/configuration/ranger-storm-security.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/STORM/0.10.0/configuration/storm-cluster-log4j.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/STORM/0.10.0/configuration/storm-env.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/STORM/0.10.0/configuration/storm-site.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/STORM/0.10.0/configuration/storm-worker-log4j.xml
>  PRE-CREATION 
>   ambari-server/src/main/resources/common-services/STORM/0.10.0/metainfo.xml 
> PRE-CREATION 
>   ambari-server/src/main/resources/common-services/STORM/0.10.0/metrics.json 
> PRE-CREATION 
>   ambari-server/src/main/resources/common-services/STORM/0.10.0/widgets.json 
> PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/alerts.json 
> ae03617477f98e1bc84ac80484e106716931f5e9 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/configuration/storm-env.xml
>  75b080ac59251faa1bb3176eea81383b2d225ec8 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/configuration/storm-site.xml
>  01b3f4e85b08031bdbd0ce907861536158ae7ab8 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/kerberos.json
>  fcfe524f6293470792404bc9296c85ab5c965c05 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/metainfo.xml 
> acb4a57bce5e3196aeab2e0810552ed7c2d7029f 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/metrics.json 
> 08c2b50f8141fe0b990a6e78d670901dac2f666c 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/alerts/check_supervisor_process_win.py
>  a698415f460b65416fd5fbd0a1644bf1c3b22a4d 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/files/wordCount.jar
>  aed64beed95e77e708e477c686a672b2163d2260 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/drpc_server.py
>  b156578781286447214358167c438cc3aaf32015 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/nimbus.py
>  b2148a560f99b4a61c8781bd312a315ffc599f34 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/nimbus_prod.py
>  39bda4df67d6e8b00d83d16860a021004d892975 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/pacemaker.py
>  2ea02e8531c4ddc6515fbb64b12b825702c5abe5 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/params.py
>  f10a3f39975dd5a030f99175fdb7947b6c830065 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/params_linux.py
>  d715a25b532aefba1c44e49322097a89bb6fd3a0 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/params_windows.py
>  88e6246d2c4583391cd9f3889abbb331cc54c34a 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/rest_api.py
>  26fdb2766e1b117547e529c586fd75f765eceb2a 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/service.py
>  6da159a15825e4cd9e0d56e9d3ecd08a9500a6d1 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/service_check.py
>  80ea0f5bee03cfd99ef1fe5cc6ac975162e78037 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/setup_atlas_storm.py
>  6c3e91f414761b2b4826b3db10ed7171e177d873 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/setup_ranger_storm.py
>  ba4c7770c689c03bfa67bdbd23a85593be901e0e 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/status_params.py
>  d84b0950a924d1811690039b9a28a0003d9eb7ae 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/storm.py
>  2d5076702f703ab80cd5ad92f597df9cd1c194b3 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/storm_upgrade.py
>  bc245c464949cd8b925fe6583103fda79bddaf2f 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/storm_yaml_utils.py
>  9d78e71990e003775eef5679903d795a7955fffc 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/supervisor.py
>  da900f93b6f3d0de38aca073b6b9510de2111c03 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/supervisor_prod.py
>  d6c3545ef0fc3cfea3e7d2149f068eeb4fe247ae 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/supervisord_service.py
>  6ff9f9ceebfc17c75aef49b18bee8b139b5bd281 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/ui_server.py
>  6551067462433e145b51e956f59f75ddc0a2d38d 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/templates/client_jaas.conf.j2
>  e8dc1223666752c269ea901a2dc04bf7c76055aa 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/templates/config.yaml.j2
>  a9760cb6aa5af940a9667efede0183cdacae204e 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/templates/storm-metrics2.properties.j2
>  9acf173c259208065ba206904af4cc7dc7617816 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/templates/storm.conf.j2
>  82a26fea9e8635be8184e42f86efbe36a9f89de3 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/templates/storm_jaas.conf.j2
>  8116492cdd7b5d88fc8b234cb899e273501dae41 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/templates/worker-launcher.cfg.j2
>  2228601ba0c2d4a0e94a97017a73f107f8f1d908 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/quicklinks/quicklinks.json
>  492f0a0bd89672440254558e4cfb19ec37c48060 
>   ambari-server/src/main/resources/common-services/STORM/0.9.1/alerts.json 
> PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1/configuration/storm-env.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1/configuration/storm-site.xml
>  PRE-CREATION 
>   ambari-server/src/main/resources/common-services/STORM/0.9.1/kerberos.json 
> PRE-CREATION 
>   ambari-server/src/main/resources/common-services/STORM/0.9.1/metainfo.xml 
> PRE-CREATION 
>   ambari-server/src/main/resources/common-services/STORM/0.9.1/metrics.json 
> PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1/package/alerts/check_supervisor_process_win.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1/package/files/wordCount.jar
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/drpc_server.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/nimbus.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/nimbus_prod.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/pacemaker.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/params.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/params_linux.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/params_windows.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/rest_api.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/service.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/service_check.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/setup_atlas_storm.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/setup_ranger_storm.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/status_params.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/storm.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/storm_upgrade.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/storm_yaml_utils.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/supervisor.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/supervisor_prod.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/supervisord_service.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/ui_server.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1/package/templates/client_jaas.conf.j2
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1/package/templates/config.yaml.j2
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1/package/templates/storm-metrics2.properties.j2
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1/package/templates/storm.conf.j2
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1/package/templates/storm_jaas.conf.j2
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1/package/templates/worker-launcher.cfg.j2
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1/quicklinks/quicklinks.json
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.3/configuration/ranger-storm-plugin-properties.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.3/configuration/storm-env.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.3/configuration/storm-site.xml
>  PRE-CREATION 
>   ambari-server/src/main/resources/common-services/STORM/0.9.3/metainfo.xml 
> PRE-CREATION 
>   ambari-server/src/main/resources/common-services/STORM/0.9.3/metrics.json 
> PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/STORM/1.0.1/configuration/ranger-storm-audit.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/STORM/1.0.1/configuration/storm-site.xml
>  PRE-CREATION 
>   ambari-server/src/main/resources/common-services/STORM/1.0.1/kerberos.json 
> PRE-CREATION 
>   ambari-server/src/main/resources/common-services/STORM/1.0.1/metainfo.xml 
> PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.1/services/STORM/metainfo.xml 
> 02322c1649c7dd300ce2513b6395c8fdc01515cd 
>   
> ambari-server/src/main/resources/stacks/HDP/2.2/services/STORM/configuration/ranger-storm-plugin-properties.xml
>  13acbffb63e7b5b22b22bd31266874398d8ba5f5 
>   
> ambari-server/src/main/resources/stacks/HDP/2.2/services/STORM/configuration/storm-env.xml
>  26568ef70c7e3d391876bb45dd30e2ad56cdc0df 
>   
> ambari-server/src/main/resources/stacks/HDP/2.2/services/STORM/configuration/storm-site.xml
>  88b93641c9a17933a1d25ffa90d8a9d98002e9d9 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/STORM/metainfo.xml 
> 318116facb4e2dccc6650b5a53c8fcd20385c522 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/STORM/metrics.json 
> 2b46faf6d1cdb60bb5f8ffc4f4e04c773650ebf1 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/services/STORM/configuration/ranger-storm-audit.xml
>  60ab1378cc354439cd9c3a5ee704a027d871ddb0 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/services/STORM/configuration/ranger-storm-plugin-properties.xml
>  f2bf888c62813dc4d5a20dc4fed70208b7b1b147 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/services/STORM/configuration/ranger-storm-policymgr-ssl.xml
>  cd0f44edccabdcb198059264f453b39b29d599fc 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/services/STORM/configuration/ranger-storm-security.xml
>  f26be4d9d4bad837fd46fd7303d88810679e7537 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/services/STORM/configuration/storm-cluster-log4j.xml
>  1114ae9c9dfcb89aef4c9aea861d7bb4dfd3d681 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/services/STORM/configuration/storm-env.xml
>  8d2da6968f34bb52d9ac0300e3baedd267d52a5d 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/services/STORM/configuration/storm-site.xml
>  6a5e6db70f8243e543fcf64f3a7ef7416b2d5a36 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/services/STORM/configuration/storm-worker-log4j.xml
>  eae2d3a1c69b161f4d2b8ed1f7c5a6591a599f4a 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/STORM/metainfo.xml 
> 29bd6a41ecbfb18d05b798014f5dfbb25c073538 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/STORM/metrics.json 
> 3d0fdd3f594ac95fe9077eebaa580e6cefc6df64 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/STORM/widgets.json 
> d22a1ede4fcec611b46830adf15425021eab9430 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/STORM/configuration/ranger-storm-audit.xml
>  bfa0fd2245892f139af5999790aafa2ae66f3e10 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/STORM/configuration/ranger-storm-policymgr-ssl.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/STORM/configuration/ranger-storm-security.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/STORM/configuration/storm-site.xml
>  19d496190a0ee331c1a64c99c8b3846bcd18303c 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/STORM/kerberos.json 
> b88dd44574fdb4f7f750dae39632938210ed5b8e 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/STORM/metainfo.xml 
> c1e9490c939440d3b72f0b83f7bf229b7f5c8cb0 
>   
> ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/STORM/alerts.json 
> e5d4e471bda82f9ecefe7f490f749e40cbfeba57 
>   
> ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/STORM/metainfo.xml
>  76022cc06a4b5d4b1c3dda6362a2265d5f823ea3 
>   ambari-server/src/test/python/stacks/2.1/STORM/test_storm_base.py 
> 023b811dee6f391b744878050025e91b81aa7301 
>   ambari-server/src/test/python/stacks/2.3/STORM/test_storm_base.py 
> 3c602348d252218daad16a83963748ceb77af643 
>   ambari-server/src/test/python/stacks/2.3/STORM/test_storm_upgrade.py 
> d0356ffc0143722bbd0233a18ba4b742f45c4aa0 
>   ambari-server/src/test/python/stacks/2.3/configs/storm_default.json 
> 72afd78894524ea2256db45e82b2fc9e6bc96745 
>   ambari-server/src/test/python/stacks/2.3/configs/storm_default_secure.json 
> c1b7e10aae5b301664ec8d5801d7618baa243c1d 
> 
> Diff: https://reviews.apache.org/r/46976/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test -DskipSurefireTests
> [INFO] 
> ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] 
> ------------------------------------------------------------------------
> [INFO] Total time: 58.650s
> [INFO] Finished at: Wed May 04 06:40:16 PDT 2016
> [INFO] Final Memory: 64M/1178M
> [INFO] 
> ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Jayush Luniya
> 
>

Reply via email to