-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47020/
-----------------------------------------------------------
Review request for Ambari and Vitalyi Brodetskyi.
Bugs: AMBARI-16273
https://issues.apache.org/jira/browse/AMBARI-16273
Repository: ambari
Description
-------
{code}
Please find the latest report on new defect(s) introduced to Apache
Ambari found with Coverity Scan.
1 new defect(s) introduced to Apache Ambari found with Coverity Scan.
New defect(s) Reported-by: Coverity Scan
Showing 1 of 1 defect(s)
** CID 151827: FindBugs: Performance (FB.SIC_INNER_SHOULD_BE_STATIC)
/ambari-server/src/main/java/org/apache/ambari/server/state/theme/Config
Co
ndition.java: 74 in ()
________________________________________________________________________
__
______________________________
*** CID 151827: FindBugs: Performance (FB.SIC_INNER_SHOULD_BE_STATIC)
/ambari-server/src/main/java/org/apache/ambari/server/state/theme/Config
Co
ndition.java: 74 in ()
68 public void setElseLabel(ConfigConditionResult elseLabel) {
69 this.elseLabel = elseLabel;
70 }
71
72 @JsonSerialize(include = JsonSerialize.Inclusion.NON_NULL)
73 @JsonIgnoreProperties(ignoreUnknown = true)
CID 151827: FindBugs: Performance
(FB.SIC_INNER_SHOULD_BE_STATIC)
Should
org.apache.ambari.server.state.theme.ConfigCondition$ConfigConditionR
es
ult be a _static_ inner class?
74 public class ConfigConditionResult {
75 @JsonProperty("property_value_attributes")
76 private ValueAttributesInfo propertyValueAttributes;
77
78 public ValueAttributesInfo getPropertyValueAttributes() {
79 return propertyValueAttributes;
{code}
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/state/theme/ConfigCondition.java
bf54f8a
Diff: https://reviews.apache.org/r/47020/diff/
Testing
-------
mvn clean test
Thanks,
Dmitro Lisnichenko
