-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47022/#review131870
-----------------------------------------------------------


Fix it, then Ship it!




The patch looks fine to me, just needs a minor fix listed below.

Regarding the open question, I don't think there is much that can be done in 
the short term on this one.  The Ambari Integration code must use a separate 
admin user to access LogSearch, so avoid the potential round-trip 
authentication from LogSearch.  

My recommendation is that this password setting still be set to required, 
especially considering that the LogSearch server itself may be configured to 
only use file-based authentication.  In either case, file-based or 
Ambari-based, the Ambari LogSearch Integration layer will still need the 
separate credential.

Thanks.


ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-admin-json.xml
 (line 26)
<https://reviews.apache.org/r/47022/#comment195912>

    I think the name should be changed to something like:
    
    "ambari_logsearch_admin"
    
    or something like that.  The name proposed in this patch will probably be a 
little confusing for users, since "ambari_user" might appear to be a username 
for logging into Ambari, when in fact this username is specifically for the 
LogSearch server.


- Robert Nettleton


On May 5, 2016, 3:48 p.m., Oliver Szabo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47022/
> -----------------------------------------------------------
> 
> (Updated May 5, 2016, 3:48 p.m.)
> 
> 
> Review request for Ambari, Robert Nettleton and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-16275
>     https://issues.apache.org/jira/browse/AMBARI-16275
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Change default username for Logsearch UI.
> Open question: if ambari_admin is used as default user, and that outcome is 
> ambari user can be used on Logsearch UI, then adding a required password can 
> be misleading.
> 
> 
> Diffs
> -----
> 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-admin-json.xml
>  ca818b9 
> 
> Diff: https://reviews.apache.org/r/47022/diff/
> 
> 
> Testing
> -------
> 
> Total run:1014
> Total errors:0
> Total failures:0
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>

Reply via email to