> On May 5, 2016, 5:30 p.m., Robert Nettleton wrote:
> > The patch looks fine to me, just needs a minor fix listed below.
> > 
> > Regarding the open question, I don't think there is much that can be done 
> > in the short term on this one.  The Ambari Integration code must use a 
> > separate admin user to access LogSearch, so avoid the potential round-trip 
> > authentication from LogSearch.  
> > 
> > My recommendation is that this password setting still be set to required, 
> > especially considering that the LogSearch server itself may be configured 
> > to only use file-based authentication.  In either case, file-based or 
> > Ambari-based, the Ambari LogSearch Integration layer will still need the 
> > separate credential.
> > 
> > Thanks.

ok. after the ambari server credential stuff goes in, maybe we will need a new 
property to use ambari-server as credential server (by default: true), in that 
patch external_auth comes from a property anyway (in logsearch.properties)


- Oliver


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47022/#review131870
-----------------------------------------------------------


On May 5, 2016, 6:18 p.m., Oliver Szabo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47022/
> -----------------------------------------------------------
> 
> (Updated May 5, 2016, 6:18 p.m.)
> 
> 
> Review request for Ambari, Robert Nettleton and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-16275
>     https://issues.apache.org/jira/browse/AMBARI-16275
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Change default username for Logsearch UI.
> Open question: if ambari_admin is used as default user, and that outcome is 
> ambari user can be used on Logsearch UI, then adding a required password can 
> be misleading.
> 
> 
> Diffs
> -----
> 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-admin-json.xml
>  ca818b9 
> 
> Diff: https://reviews.apache.org/r/47022/diff/
> 
> 
> Testing
> -------
> 
> Total run:1014
> Total errors:0
> Total failures:0
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>

Reply via email to