----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47038/#review131959 -----------------------------------------------------------
Ship it! Ship It! - Jayush Luniya On May 5, 2016, 7:44 p.m., Nate Cole wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47038/ > ----------------------------------------------------------- > > (Updated May 5, 2016, 7:44 p.m.) > > > Review request for Ambari, Jonathan Hurley and Jayush Luniya. > > > Bugs: AMBARI-16279 > https://issues.apache.org/jira/browse/AMBARI-16279 > > > Repository: ambari > > > Description > ------- > > The HostComponentResourceProvider will find the available Resources (host > components) to update. When this set is empty, then an Iterator > NoSuchElementException gets thrown. > > Note: had a discussion with other committers and felt that 204 is an > appropriate response in the case where there is nothing to update. However, > code exists already whereby a 200 is returned. I believe this to be > inappropriate, but cannot change it as it could change the UI in an > unexpected way. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostComponentResourceProvider.java > 83bfeaa > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostComponentResourceProviderTest.java > 683a235 > > Diff: https://reviews.apache.org/r/47038/diff/ > > > Testing > ------- > > Manual. Automated pending. > > > Thanks, > > Nate Cole > >