-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47027/#review132034
-----------------------------------------------------------




ambari-views/src/main/java/org/apache/ambari/view/AmbariClusterStreamProvider.java
 (line 28)
<https://reviews.apache.org/r/47027/#comment196084>

    How is this different from AmbariStreamProvider which does not use an 
existing session? Isn't that the same thing as a remote Ambari cluster?



ambari-views/src/main/java/org/apache/ambari/view/ClusterType.java (line 27)
<https://reviews.apache.org/r/47027/#comment196085>

    Doesn't have to be one or the other - NONE doesn't seem to make sense here.



contrib/views/capacity-scheduler/src/main/java/org/apache/ambari/view/capacityscheduler/ConfigurationService.java
 (line 121)
<https://reviews.apache.org/r/47027/#comment196086>

    Why is this commented out?



contrib/views/capacity-scheduler/src/main/java/org/apache/ambari/view/capacityscheduler/ConfigurationService.java
 (lines 313 - 338)
<https://reviews.apache.org/r/47027/#comment196088>

    What's going on with this method? Why is validation no longer required?



contrib/views/capacity-scheduler/src/main/resources/view.xml (line 27)
<https://reviews.apache.org/r/47027/#comment196090>

    How is this going to impact existing deployments of this view? Removing 
these has to have some consequence in the UI?


- Jonathan Hurley


On May 5, 2016, 12:35 p.m., Gaurav Nagar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47027/
> -----------------------------------------------------------
> 
> (Updated May 5, 2016, 12:35 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Jonathan Hurley, Nitiraj 
> Rathore, Pallav Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.
> 
> 
> Bugs: AMBARI-16274
>     https://issues.apache.org/jira/browse/AMBARI-16274
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Added AmbariClusterStreamProvider interface for connecting to Ambari Cluster 
> (Can be Remote or Local) that is attached to view instance.
> Added Cluster Type Enum (LOCAL_AMBARI, REMOTE_AMBARI, NONE) for 
> differentiating cluster type attached to view instance.
> 
> 
> Diffs
> -----
> 
>   
> ambari-views/src/main/java/org/apache/ambari/view/AmbariClusterStreamProvider.java
>  PRE-CREATION 
>   ambari-views/src/main/java/org/apache/ambari/view/AmbariHttpException.java 
> PRE-CREATION 
>   ambari-views/src/main/java/org/apache/ambari/view/AmbariStreamProvider.java 
> ce91676 
>   ambari-views/src/main/java/org/apache/ambari/view/ClusterType.java 
> PRE-CREATION 
>   ambari-views/src/main/java/org/apache/ambari/view/ViewContext.java 7b7b025 
>   
> ambari-views/src/main/java/org/apache/ambari/view/ViewInstanceDefinition.java 
> 0c3d3ce 
>   ambari-views/src/main/resources/view.xsd 04902e9 
>   
> contrib/views/capacity-scheduler/src/main/java/org/apache/ambari/view/capacityscheduler/ConfigurationService.java
>  7f1d489 
>   contrib/views/capacity-scheduler/src/main/resources/view.xml 6dc3ffa 
>   
> contrib/views/capacity-scheduler/src/test/java/org/apache/ambari/view/capacityscheduler/ConfigurationServiceTest.java
>  62fa21e 
>   
> contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/uploads/UploadService.java
>  83eae9b 
>   
> contrib/views/slider/src/main/java/org/apache/ambari/view/slider/rest/client/BaseHttpClient.java
>  b4fccf9 
>   
> contrib/views/utils/src/main/java/org/apache/ambari/view/utils/ambari/AmbariApi.java
>  6b88b6f 
>   
> contrib/views/utils/src/main/java/org/apache/ambari/view/utils/ambari/Services.java
>  a8ef43f 
>   
> contrib/views/utils/src/main/java/org/apache/ambari/view/utils/ambari/URLStreamProviderBasicAuth.java
>  c9f735a 
>   
> contrib/views/utils/src/main/java/org/apache/ambari/view/utils/hdfs/AuthConfigurationBuilder.java
>  c8ca6cd 
>   
> contrib/views/utils/src/main/java/org/apache/ambari/view/utils/hdfs/ConfigurationBuilder.java
>  4518ac6 
>   
> contrib/views/utils/src/test/java/org/apache/ambari/view/utils/ambari/RemoteClusterTest.java
>  ec4df7d 
>   
> contrib/views/utils/src/test/java/org/apache/ambari/view/utils/ambari/ServicesTest.java
>  455ca20 
>   
> contrib/views/utils/src/test/java/org/apache/ambari/view/utils/ambari/URLStreamProviderBasicAuthTest.java
>  27e98f2 
> 
> Diff: https://reviews.apache.org/r/47027/diff/
> 
> 
> Testing
> -------
> 
> Manual Testing
> 
> 
> Thanks,
> 
> Gaurav Nagar
> 
>

Reply via email to