> On May 6, 2016, 10:38 a.m., Jonathan Hurley wrote:
> > contrib/views/capacity-scheduler/src/main/java/org/apache/ambari/view/capacityscheduler/ConfigurationService.java,
> >  line 121
> > <https://reviews.apache.org/r/47027/diff/1/?file=1373623#file1373623line121>
> >
> >     Why is this commented out?
> 
> Gaurav Nagar wrote:
>     No need to validate as Remote Ambari Cluster properties is now managed by 
> view framework.

Then it should be removed instead of commented out.


> On May 6, 2016, 10:38 a.m., Jonathan Hurley wrote:
> > contrib/views/capacity-scheduler/src/main/resources/view.xml, lines 27-50
> > <https://reviews.apache.org/r/47027/diff/1/?file=1373624#file1373624line27>
> >
> >     How is this going to impact existing deployments of this view? Removing 
> > these has to have some consequence in the UI?
> 
> Gaurav Nagar wrote:
>     The existing capicity-scheduler view which is configured as local cluster 
> will work fine. But the instance with custom configuration will not work. 
>     We had some ideas around this, and filed a jira for tracking this. 
> https://issues.apache.org/jira/browse/AMBARI-16289
>     For admin ui. As the view depends on ambari managed cluster, only Local 
> cluster and Remote cluster section is shown. Custom Configuration section is 
> not shown for the view.

OK, as long as there is a Jira tracking this.


> On May 6, 2016, 10:38 a.m., Jonathan Hurley wrote:
> > contrib/views/capacity-scheduler/src/main/java/org/apache/ambari/view/capacityscheduler/ConfigurationService.java,
> >  lines 319-344
> > <https://reviews.apache.org/r/47027/diff/1/?file=1373623#file1373623line319>
> >
> >     What's going on with this method? Why is validation no longer required?
> 
> Gaurav Nagar wrote:
>     As Remote Ambari Cluster implementation is now provided by Ambari View 
> Framework,these properties are no longer required for the view. So no need to 
> validate them.
>     As these are validated when creating Remote Cluster

That's fine - but it should be removed then.


- Jonathan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47027/#review132034
-----------------------------------------------------------


On May 5, 2016, 12:35 p.m., Gaurav Nagar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47027/
> -----------------------------------------------------------
> 
> (Updated May 5, 2016, 12:35 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Jonathan Hurley, Nitiraj 
> Rathore, Pallav Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.
> 
> 
> Bugs: AMBARI-16274
>     https://issues.apache.org/jira/browse/AMBARI-16274
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Added AmbariClusterStreamProvider interface for connecting to Ambari Cluster 
> (Can be Remote or Local) that is attached to view instance.
> Added Cluster Type Enum (LOCAL_AMBARI, REMOTE_AMBARI, NONE) for 
> differentiating cluster type attached to view instance.
> 
> 
> Diffs
> -----
> 
>   
> ambari-views/src/main/java/org/apache/ambari/view/AmbariClusterStreamProvider.java
>  PRE-CREATION 
>   ambari-views/src/main/java/org/apache/ambari/view/AmbariHttpException.java 
> PRE-CREATION 
>   ambari-views/src/main/java/org/apache/ambari/view/AmbariStreamProvider.java 
> ce91676 
>   ambari-views/src/main/java/org/apache/ambari/view/ClusterType.java 
> PRE-CREATION 
>   ambari-views/src/main/java/org/apache/ambari/view/ViewContext.java 7b7b025 
>   
> ambari-views/src/main/java/org/apache/ambari/view/ViewInstanceDefinition.java 
> 0c3d3ce 
>   ambari-views/src/main/resources/view.xsd 04902e9 
>   
> contrib/views/capacity-scheduler/src/main/java/org/apache/ambari/view/capacityscheduler/ConfigurationService.java
>  7f1d489 
>   contrib/views/capacity-scheduler/src/main/resources/view.xml 6dc3ffa 
>   
> contrib/views/capacity-scheduler/src/test/java/org/apache/ambari/view/capacityscheduler/ConfigurationServiceTest.java
>  62fa21e 
>   
> contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/uploads/UploadService.java
>  83eae9b 
>   
> contrib/views/slider/src/main/java/org/apache/ambari/view/slider/rest/client/BaseHttpClient.java
>  b4fccf9 
>   
> contrib/views/utils/src/main/java/org/apache/ambari/view/utils/ambari/AmbariApi.java
>  6b88b6f 
>   
> contrib/views/utils/src/main/java/org/apache/ambari/view/utils/ambari/Services.java
>  a8ef43f 
>   
> contrib/views/utils/src/main/java/org/apache/ambari/view/utils/ambari/URLStreamProviderBasicAuth.java
>  c9f735a 
>   
> contrib/views/utils/src/main/java/org/apache/ambari/view/utils/hdfs/AuthConfigurationBuilder.java
>  c8ca6cd 
>   
> contrib/views/utils/src/main/java/org/apache/ambari/view/utils/hdfs/ConfigurationBuilder.java
>  4518ac6 
>   
> contrib/views/utils/src/test/java/org/apache/ambari/view/utils/ambari/RemoteClusterTest.java
>  ec4df7d 
>   
> contrib/views/utils/src/test/java/org/apache/ambari/view/utils/ambari/ServicesTest.java
>  455ca20 
>   
> contrib/views/utils/src/test/java/org/apache/ambari/view/utils/ambari/URLStreamProviderBasicAuthTest.java
>  27e98f2 
> 
> Diff: https://reviews.apache.org/r/47027/diff/
> 
> 
> Testing
> -------
> 
> Manual Testing
> 
> 
> Thanks,
> 
> Gaurav Nagar
> 
>

Reply via email to