> On May 6, 2016, 2:29 p.m., Jonathan Hurley wrote: > > These property renames - I don't see them being handled for upgrades. How > > are existing clusters going to adapt to these changes?
These properties are introduced in 2.5 stack only which is not released yet. Upgrading to 2.5 will auto-merge newly added configs. > On May 6, 2016, 2:29 p.m., Jonathan Hurley wrote: > > ambari-common/src/main/python/resource_management/libraries/functions/stack_features.py, > > line 239 > > <https://reviews.apache.org/r/47060/diff/1/?file=1374559#file1374559line239> > > > > Description would be nice for developers wondering what this is. Updated in latest patch > On May 6, 2016, 2:29 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py, > > line 230 > > <https://reviews.apache.org/r/47060/diff/1/?file=1374560#file1374560line230> > > > > Not using default? It's 100% guaranteed to be there? These wont fail, because of the lazy failing implemented. CC @Andrew Onishuk who had asked in one of the earlier RR to use this feature instead of default(). > On May 6, 2016, 2:29 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py, > > lines 246-247 > > <https://reviews.apache.org/r/47060/diff/1/?file=1374560#file1374560line246> > > > > Guaranteed to be on every cluster - new and old - always? Same as above comment - Mugdha ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47060/#review132031 ----------------------------------------------------------- On May 9, 2016, 5:58 a.m., Mugdha Varadkar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47060/ > ----------------------------------------------------------- > > (Updated May 9, 2016, 5:58 a.m.) > > > Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Gautam > Borad, Jonathan Hurley, Jayush Luniya, and Velmurugan Periasamy. > > > Bugs: AMBARI-16285 > https://issues.apache.org/jira/browse/AMBARI-16285 > > > Repository: ambari > > > Description > ------- > > Changes include: > 1) Renaming properties in ranger-tagsync-site.xml introduced in stack -2.5 > followed by theme change. > 2) Removed tagsync user password introduced in previous patch > 3) Add default password in jceks for rangertagsync and rangerusersync > 4) Derive tag source as ATLAS, if ATLAS is installed > 5) Added new properties under ranger-ugsync-site.xml related to Policy > manager user's credentials in Ranger usersync service > > > Diffs > ----- > > > ambari-common/src/main/python/resource_management/libraries/functions/constants.py > abd2212 > > ambari-common/src/main/python/resource_management/libraries/functions/stack_features.py > daa97de > > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py > 59190fe > > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_tagsync.py > 1b56044 > > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_usersync.py > d013371 > > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py > ec0eea1 > > ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json > aabc37d > > ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER/configuration/ranger-tagsync-site.xml > 08f6235 > > ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER/configuration/ranger-ugsync-site.xml > 10ef1a8 > > ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER/configuration/tagsync-application-properties.xml > d369098 > > ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER/themes/theme_version_3.json > 19411d4 > ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py > 37e6ef6 > ambari-web/app/styles/widgets.less f385449 > > Diff: https://reviews.apache.org/r/47060/diff/ > > > Testing > ------- > > Tested Ranger Tagsync on centos 6. > > > Thanks, > > Mugdha Varadkar > >
