----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47130/ -----------------------------------------------------------
Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and Jayush Luniya. Bugs: AMBARI-16380 https://issues.apache.org/jira/browse/AMBARI-16380 Repository: ambari Description ------- The ServiceCheck prerequisite check was checking all service checks, not solely the most recent ones. So even if Service Checks were run again, the prereq check was still failing on the old runs: * Changed the query to only pull back SERVICE_CHECK records using a Predicate. * Considered a stale config check, but that was adding complexity where none is needed (debatable). Diffs ----- ambari-server/src/main/java/org/apache/ambari/server/checks/ServiceCheckValidityCheck.java 8b39863 ambari-server/src/test/java/org/apache/ambari/server/checks/ServiceCheckValidityCheckTest.java 4a3ae5c Diff: https://reviews.apache.org/r/47130/diff/ Testing ------- Manual. Automated pending. Thanks, Nate Cole