----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47138/#review132354 -----------------------------------------------------------
Ship it! Ship It! - Matt On May 9, 2016, 4:43 p.m., Lav Jain wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47138/ > ----------------------------------------------------------- > > (Updated May 9, 2016, 4:43 p.m.) > > > Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, Goutam > Tadi, jun aoki, Matt, and Tim Thorpe. > > > Bugs: AMBARI-16378 > https://issues.apache.org/jira/browse/AMBARI-16378 > > > Repository: ambari > > > Description > ------- > > ``` > def getHostsForSlaveComponent(self, services, hosts, component, hostsList, > hostsComponentsMap, freeHosts): > componentName = component["StackServiceComponents"]["component_name"] > > if component["StackServiceComponents"]["cardinality"] == "ALL": > return hostsList > > componentIsPopulated = self.isComponentHostsPopulated(component) > if componentIsPopulated: > return component["StackServiceComponents"]["hostnames"] > > hostsForComponent = [] > > if self.isSlaveComponent(component): > cardinality = str(component["StackServiceComponents"]["cardinality"]) > if self.isComponentUsingCardinalityForLayout(component) and cardinality: > # cardinality types: 1+, 1-2, 1 > ``` > > The correct parameter name is comonentName (instead of component) > > > Diffs > ----- > > ambari-server/src/main/resources/stacks/stack_advisor.py 00b9d79 > > Diff: https://reviews.apache.org/r/47138/diff/ > > > Testing > ------- > > Tested manually > > > Thanks, > > Lav Jain > >
