-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47140/#review132394
-----------------------------------------------------------


Ship it!





ambari-server/src/main/java/org/apache/ambari/server/events/listeners/alerts/AlertStateChangedListener.java
 (line 192)
<https://reviews.apache.org/r/47140/#comment196582>

    "the an"?  Don't fix unless there are other changes.


- Robert Levas


On May 9, 2016, 7:36 p.m., Jonathan Hurley wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47140/
> -----------------------------------------------------------
> 
> (Updated May 9, 2016, 7:36 p.m.)
> 
> 
> Review request for Ambari and Robert Levas.
> 
> 
> Bugs: AMBARI-16410
>     https://issues.apache.org/jira/browse/AMBARI-16410
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Ambari reports alerts and triggers notifications during a stack upgrade. In 
> most cases, alert notifications should be suppressed during the upgrade to 
> prevent false positives. 
> 
> However, some alerts, such as those which don't related to the cluster, 
> should remain fully operational:
> 
> - Host disk space
> - Upgrade not finalized
> - Ambari Server Performance
> 
> 
> Diffs
> -----
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/events/listeners/alerts/AlertStateChangedListener.java
>  21584fb 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/alerts/AlertStateChangedEventTest.java
>  f76867a 
> 
> Diff: https://reviews.apache.org/r/47140/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>

Reply via email to